feat: fix IModularAccount to return address of the account for native functions #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0xrubes
approved these changes
Nov 27, 2024
jaypaik
changed the base branch from
11-22-feat_update_validationdataview_with_validationflags
to
graphite-base/208
jaypaik
force-pushed
the
11-26-feat_fix_imodularaccount_to_return_address_of_the_account_for_native_functions
branch
from
05058df to
81abe15
Compare
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 81abe15 |
jaypaik
deleted the
11-26-feat_fix_imodularaccount_to_return_address_of_the_account_for_native_functions
branch
OverviewOctane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉 🔗 Commit Hash: 81abe15 |
jaypaik
added a commit
that referenced
this pull request
Nov 27, 2024
… functions (#208) The reference implementation currently returns `address(this)` which is the address of the account for `ExecutionDataView`'s `module` field. However, the standard currently contradicts this by saying we should return `address(0)` for native functions. The better design seems to be to return the address of the account since the zero address would also be returned for nonexistent selectors, and it would be difficult to differentiate in those cases. The client should have the address of the account handy so it'd be easy to compare it against what is returned to check if it's a native function or not. Thanks @0xrubes for bringing this up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference implementation currently returns
address(this)which is the address of the account forExecutionDataView'smodulefield. However, the standard currently contradicts this by saying we should returnaddress(0)for native functions.The better design seems to be to return the address of the account since the zero address would also be returned for nonexistent selectors, and it would be difficult to differentiate in those cases.
The client should have the address of the account handy so it'd be easy to compare it against what is returned to check if it's a native function or not.
Thanks @0xrubes for bringing this up!