Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Codesize fix without split contract #24

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

adam-alchemy
Copy link
Contributor

Motivation

The code size fix applied in #19 works, but requires a more complicated deployment setup that is undesirable.

Solution

Revert the split-code plugin manager contract, and tune the compiler's optimizer target runs value to give lower priority to function inlining. This brings UpgradeableModularAccount under the code size limit, to 24.45 kb.

Also remove the unneeded compiler warning suppression for no receive function definition, and add it to the MockPlugin test utility.

Copy link
Collaborator

@jaypaik jaypaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@adam-alchemy adam-alchemy merged commit 0481d80 into main Jan 10, 2024
3 checks passed
@adam-alchemy adam-alchemy deleted the adam/size-fix-simple branch January 10, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants