Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop increment issue and add test #4

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

adam-alchemy
Copy link
Contributor

Motivation

There's a bug in the loop increment for the loupe functions for retrieving execution hooks and permitted call hooks: it is duplicated across the for loop line and at the end of the loop, within an unchecked block.

Thank you @leekt for finding this issue.

Solution

Remove the extra loop increment, and add a test that retrieves >1 execution hooks and permitted call hooks.

@adam-alchemy adam-alchemy merged commit 008f366 into main Nov 1, 2023
3 checks passed
@jaypaik jaypaik deleted the adam/fix-loop-increment branch January 11, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants