feat: [v0.8-develop, experimental] signature validator interface #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previous, ERC-1271 support for 6900 accounts was left up to plugin implementation. This could cause potential function definition conflicts, and we can address this by adding it to the validation interface and supporting multiple validation plugins at once (erc6900/resources#4).
This is an experimental implementation to gather feedback on the proposed change.
Solution
Following the miniMSA pattern of defining
isValidSignatureWithSender
, rather than the standard 1271 function.Fully implementing signature validation switching depends on multi-validation support, so that isn't implemented here. Instead, the old defined signature validator is used. This change is intended to cover the expansion to the plugin interface.