Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [v0.8-develop, experimental] signature validator interface #42

Conversation

adam-alchemy
Copy link
Contributor

Motivation

Previous, ERC-1271 support for 6900 accounts was left up to plugin implementation. This could cause potential function definition conflicts, and we can address this by adding it to the validation interface and supporting multiple validation plugins at once (erc6900/resources#4).

This is an experimental implementation to gather feedback on the proposed change.

Solution

Following the miniMSA pattern of defining isValidSignatureWithSender, rather than the standard 1271 function.
Fully implementing signature validation switching depends on multi-validation support, so that isn't implemented here. Instead, the old defined signature validator is used. This change is intended to cover the expansion to the plugin interface.

@adamegyed
Copy link
Contributor

Closing, as this was superseded by #59

@adamegyed adamegyed closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants