Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to 4337 v0.7 (2/n) #49

Merged
merged 10 commits into from
May 1, 2024
Merged

chore: update to 4337 v0.7 (2/n) #49

merged 10 commits into from
May 1, 2024

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented Apr 20, 2024

Changes:

  1. Upgrade OZ to v5.0.0
  2. Update: Remove ERC777 usage
  3. Update: Create MockERC721 to replace the previous usage of OZ ERC721 preset
  4. Update: OZ UUPSUpgradeable
  5. Simplify: switch from AccountStorageInitializable to OZ's Initializible

@howydev howydev force-pushed the howy/4337-v0.7-update-2 branch from 4799e7a to c2a4d1f Compare April 20, 2024 21:05
@howydev howydev force-pushed the howy/4337-v0.7-update-1 branch from f0a3643 to 5b2e647 Compare April 20, 2024 21:07
@howydev howydev force-pushed the howy/4337-v0.7-update-2 branch from c2a4d1f to 248e43b Compare April 20, 2024 21:08
@howydev howydev marked this pull request as draft April 20, 2024 21:08
@howydev howydev marked this pull request as ready for review April 22, 2024 16:18
adam-alchemy
adam-alchemy reviewed Apr 22, 2024
View reviewed changes
src/account/AccountStorage.sol Outdated Show resolved Hide resolved
src/account/UpgradeableModularAccount.sol Outdated Show resolved Hide resolved
@howydev howydev force-pushed the howy/4337-v0.7-update-2 branch from 248e43b to 2472fd9 Compare April 23, 2024 17:52
@CodesMcCabe CodesMcCabe mentioned this pull request Apr 25, 2024
Closed
@howydev howydev requested review from adam-alchemy and jaypaik April 29, 2024 15:48
adam-alchemy
adam-alchemy approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because most parts look good to me, but I had a question about the internal function call for upgradeToAndCall.

src/account/UpgradeableModularAccount.sol Outdated Show resolved Hide resolved
@howydev howydev merged commit 145acbb into howy/4337-v0.7-update-1 May 1, 2024
3 checks passed
@howydev howydev deleted the howy/4337-v0.7-update-2 branch May 1, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-alchemy adam-alchemy adam-alchemy approved these changes

@jaypaik jaypaik Awaiting requested review from jaypaik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howydev @jaypaik @adam-alchemy