Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently,
_doPreExecHooks
in contractUpgradeableModularAccount
usemsg.sig
to getpostExecHook
.However, the input parameter
selector
is not always equal tomsg.sig
. In the case ofexecuteFromPlugin(bytes calldata data)
, the input parameterselector
isbytes4(data[:4])
and msg.sig isIPluginExecutor.executeFromPlugin.selector
.Solution
The solution is using input parameter
selector
to fetch postHook instead ofmsg.sig
.