[DRAFT] feat: Composable Validation #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangting-alchemy
force-pushed
the
fangting/comp-valid
branch
3 times, most recently
from
c9e7f05 to
8aa1f09
Compare
fangting-alchemy
force-pushed
the
fangting/comp-valid
branch
from
8aa1f09 to
50e2f44
Compare
fangting-alchemy
force-pushed
the
fangting/comp-valid
branch
2 times, most recently
from
f0a899c to
68a8f3a
Compare
fangting-alchemy
force-pushed
the
fangting/comp-valid
branch
from
68a8f3a to
8026eec
Compare
| sender != msg.sender | ||
| && ( | ||
| _owners[msg.sender].data.length == 0 | ||
| || sender != abi.decode(_owners[msg.sender].data, (address)) |
There was a problem hiding this comment.
This is not guaranteed to have this abi encoding though, right? For example for WebAuthnValidator has a different encoding to ECDSA one which is assumed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkout doc here
WebAuthn lib base
Summary
This PR demonstrate a stateless validation system where validators are composable. It consists of two components: Validation plugin functions and stateless validators.
Validation plugins manage MA account’s authorization and authentication rules.
Stateless Validators validate inputs based on root rules of the validation scheme.
See more details in the above Google doc.
Note: it does not include WebAuthn Validator tests here due to time and scope.