feat: [v0.8-develop] remove duplicate test factory [2/2] #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangting-alchemy
approved these changes
Jul 11, 2024
adamegyed
force-pushed
the
adam/SOP-install-validation
branch
from
9315a17 to
cdd7a7a
Compare
adamegyed
force-pushed
the
adam/dedupe-test-factory
branch
from
c900450 to
801ee56
Compare
adamegyed
force-pushed
the
adam/SOP-install-validation
branch
from
cdd7a7a to
a879a96
Compare
adamegyed
force-pushed
the
adam/dedupe-test-factory
branch
from
801ee56 to
9a102a3
Compare
adamegyed
force-pushed
the
adam/dedupe-test-factory
branch
from
9a102a3 to
9d56e26
Compare
adamegyed
added a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the update to the installation flow for
SingleOwnerPluginfrom #91, there's no longer a need to have a separate factory just for default validation.Solution
Delete the duplicate factory flow, and update usages in tests.