-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/n] Introduce EntityId in account and plugins #93
Conversation
I'm on board for renaming Curious if you have any other naming ideas. |
The goal of the naming change for |
|
Yeah this is starting to make sense to me, I like the I still think adding "Packed" to the name is unnecessary. In general, conciseness leads to more readable code. And in this case specifically, because it's not distinguishing it from a different type, I think it's unnecessary. There is no "Unpacked" version, like |
Maybe |
They're already unique by not having location specifiers ( |
Good point. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have a few small nits
@@ -12,81 +12,81 @@ import {FunctionReference, ValidationConfig} from "../interfaces/IPluginManager. | |||
// 0x______________________________________________000000000000000000 // unused | |||
|
|||
library ValidationConfigLib { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: could we update the comments in L8-L12 on layout also?
src/account/AccountStorage.sol
Outdated
@@ -75,18 +75,18 @@ function toFunctionReference(bytes32 setValue) pure returns (FunctionReference) | |||
// 0x____________________________________________BB__________________ is post hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: prefer to update these
1a3dfc4
to
1f8c965
Compare
…introduce validationId
52391bb
to
87a45aa
Compare
…w multiple validation installation on account (#93)
…w multiple validation installation on account (#93)
[1/n]: Introduce entityId with type
uint32
. Remove functionId. This PR only updates the types and names and any code logic depends on the type. Storage and other code logic of entityId will be introduced in the follow up PRs.Context: