Generalized multi-level relaxation #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of an affect on the boundaries than expected.
…rners. The mask seems OK but the logic is hard to follow.
…will be overwritten with FIP. Need to remove G2E from fast_rhs.
asalmgren
approved these changes
Sep 9, 2023
|
@WeiqunZhang can you focus on the ERF_FillPatcher.cpp/.H files? The new code for generating the mask array for set and relax regions is here. |
WeiqunZhang
reviewed
Sep 28, 2023
| com_ba.define(com_bl); | ||
| com_ba.complementIn(com_bl, fba_bnd); | ||
|
|
||
| // Fill mask based upon the com_bl BoxList |
There was a problem hiding this comment.
There is a more efficient way to do this. Since this pattern of setVal in a BoxArray's region can be useful in other places, I will add a function to amrex. After that is merged, we can do a new PR to use it.
Co-authored-by: Weiqun Zhang <[email protected]>
Co-authored-by: Weiqun Zhang <[email protected]>
Co-authored-by: Weiqun Zhang <[email protected]>
WeiqunZhang
reviewed
Sep 28, 2023
WeiqunZhang
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the mask array in ERFFillPatcher.cpp is a bit off a mess. The code works but it is hard to follow and not perfectly general.
The tradeoff between space and time interpolation has not been assessed. We currently do both for all the fill calls; this should be modified (currently inefficient).
Grids to evolve has been removed. With the fast integrator, we will compute an update on all interior cells; but the set region is overwritten because we call apply_bcs() at the end of a fast iteration.