Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QKE src fixes #1252

Merged
merged 4 commits into from
Sep 19, 2023
Merged

QKE src fixes #1252

merged 4 commits into from
Sep 19, 2023

Conversation

AMLattanzi
Copy link
Collaborator

  1. Dissipation must be subtracted from the RHS
  2. Buoyancy source is \sim <w' \theta'> but -<w' \theta'> \sim k*dthetadz, so the buoyancy term should be negative
  3. The GH term should have (g/theta_0) from Nakanishi & Niino; see Eq. (23).

This ran and was stable for many time steps and the QKE field looked reasonable.

@AMLattanzi AMLattanzi requested a review from baperry2 September 19, 2023 19:59
baperry2
baperry2 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@baperry2 baperry2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can add one more fix here (also runs stably for many timesteps): AMLattanzi#1

@AMLattanzi AMLattanzi merged commit 114f2cf into erf-model:development Sep 19, 2023
@AMLattanzi AMLattanzi deleted the MoreQKEFixes branch September 19, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baperry2 baperry2 baperry2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMLattanzi @baperry2