Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moisture typos #1257

Closed
wants to merge 1 commit into from
Closed

Conversation

AMLattanzi
Copy link
Collaborator

  • crain is defined on L79 of ERF_Constans.H as constexpr amrex::Real crain = b_rain / 4.0;. Similarly, the other constants are defined in the same manner.

However, the precipitating fluxes have the following closure:
image

Therefore, the std::pow() functions do not utilize the correct exponent. The negative and 1.0 should correct this.

@AMLattanzi AMLattanzi requested a review from xyuan September 26, 2023 20:54
@AMLattanzi AMLattanzi changed the title Moisture typose Moisture typos Sep 26, 2023
@AMLattanzi AMLattanzi closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant