Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up box defs in Vel to Mom. #1258

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

AMLattanzi
Copy link
Collaborator

When converting from velocity to momentum, we by default need one lateral ghost cell to be filled. With numerical diffusion, we need all of them filled (due to the stencil width). I also don't see why we should be growing a tilebox; this should lead to overlap in the thread operations (presumably safe since it's just writing but inefficient I think).

@dwillcox
Copy link
Contributor

dwillcox commented Oct 2, 2023

Given that explanation, this makes sense to me and is much simpler!

@AMLattanzi AMLattanzi merged commit 6dea2f3 into erf-model:development Oct 2, 2023
12 checks passed
@AMLattanzi AMLattanzi deleted the VelToMom branch October 2, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants