Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing WPS test. #1261

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

AMLattanzi
Copy link
Collaborator

Summary of changes and rationale:

  1. The indexing in fill_from_wrfbdy needed revamping. This is due to the fact that FillIntermediatePatch may call this routine under conditions when only cons vars should be filled or a subset of cons vars (see set_bcs after fast rhs). The new indexing makes the operations only occur on what we want to set.
  2. The corner regions in bx_xlo and bx_xhi of fill_from_wrfbdy will incorrectly reach into a set region when the variable is NOT read. We want to copy from a valid interior cell.
  3. The deletion of grids_to_evolve will make the microphysics call cloud() in the set region. So the diagnosed quantities (qv, qc) will never match because we now operate on cells we didn't use to. We can remake the benchmark or we can exclude the qv and qc quantities.

@AMLattanzi AMLattanzi requested a review from asalmgren October 5, 2023 22:05
@asalmgren
Copy link
Collaborator

Just for conciseness let's consolidate lines like

int var_idx_end = Vars::NumTypes;
if (cons_only) var_idx_end = Vars::cons + 1;

into

int var_idx_end = cons_only ? Vars::cons+1 : Vars::NumTypes;

@AMLattanzi
Copy link
Collaborator Author

Changes adopted in two places in commit 37a67a8

…tly impose boundary conditions on those vars.
@AMLattanzi AMLattanzi merged commit d31ad0a into erf-model:development Oct 6, 2023
12 checks passed
@AMLattanzi AMLattanzi deleted the WPS_Fix branch October 6, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants