Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPS Fix #1343

Closed
wants to merge 2 commits into from
Closed

WPS Fix #1343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2d99f3
Fixes bug with qv+qc+qi vs qt at t==0.
AMLattanzi Dec 13, 2023
b993bfb
Merge branch 'development' into WPSfix
asalmgren Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Source/ERF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,25 @@ ERF::InitData ()
}
}

// Initialize microphysics here
micro.define(solverChoice);

// Call Init which will call Diagnose to fill qmoist
// NOTE: We must populate qmoist after the BCs are filled with FillPatch.
// With forcing on lateral BCs, we need to pick up interio Dirichlet cells.
if (solverChoice.moisture_type != MoistureType::None)
{
for (int lev = 0; lev <= finest_level; ++lev)
{
// If not restarting we need to fill qmoist given qt and qp.
if (restart_chkfile.empty()) {
micro.Init(vars_new[lev][Vars::cons], *(qmoist[lev]),
grids[lev], Geom(lev), 0.0); // dummy value, not needed just to diagnose
micro.Update(vars_new[lev][Vars::cons], *(qmoist[lev]));
}
}
}

if (restart_chkfile.empty() && check_int > 0)
{
#ifdef ERF_USE_NETCDF
Expand Down
Loading