Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #1400

Closed
wants to merge 4 commits into from
Closed

Bug fixes #1400

wants to merge 4 commits into from

Conversation

AMLattanzi
Copy link
Collaborator

This PR corrects 3 bugs.

  1. The bdy data must be written and read with init_type=metgrid
  2. The metgrid initialization should not multiply Qv by rho when populating the FABs_for_BCs. The rho multiplication is already done in init_base_state.
  3. The lateral BC routines do not protect against accessing z<dom_lo.z or z>dom_hi.z and they should. These guards were on specific loops for cons vars but not everywhere. This can cause some erroneous operations when restarting from a chk file.

@AMLattanzi AMLattanzi requested a review from asalmgren January 25, 2024 17:05
@AMLattanzi AMLattanzi closed this Jan 25, 2024
@AMLattanzi AMLattanzi deleted the BugFixes branch February 1, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalmgren asalmgren Awaiting requested review from asalmgren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AMLattanzi