Template land and sea MOST iters #1654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WeiqunZhang can you provide some insight on the SYCL failure and whether this PR can be modified to circumnavigate said issue? |
|
Virtual functions are not supported on GPUs. This is not just a SYCL issue. It's a compile time issue for SYCL, but a run time issue for CUDA. The latter is arguably worse. Even for CPU, the current approach of using virtual functions inside loops over cells is bad for performance. You have to go back to the old approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to do two loops over the MOST iters for each step. Instead, we define a base struct that has the iteration signature (used by all other derived structs). We then find the struct type we want and pass that through the templated wrapper. This was only compile tested.