Fix NumDiff with substepping and add a vertical option. #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numerical diffusion option did not work with substepping due to an erroneous arithmetic operation. The root cause of the issue was an inconsistency between the number of ghost cells filled after the fast integrator and the number of ghost cells operated on by
VelocityToMomentum. This PR corrects that issue (tested in DEBUG withExec/ABL/inputs_numdiff. Additionally, a vertical numerical diffusion function was added for potential testing with the BOMEX simulation (no direct plugin yet).