Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface for NOAH-MP Landsurface model #1835

Merged
merged 19 commits into from
Oct 24, 2024

Conversation

akashdhruv
Copy link
Contributor

The interface is under active development. However, I am creating this PR to ensure that it is integrated with the regression testing framework. Supporting documentation to follow.

@akashdhruv
Copy link
Contributor Author

Ran local tests after a merge with latest development branch and things are breaking particularly related to this PR: #1833

@akashdhruv akashdhruv marked this pull request as draft October 3, 2024 01:01
@asalmgren
Copy link
Collaborator

@akashdhruv -- there have been more changes to the cmake stuff -- can you try again?

@akashdhruv
Copy link
Contributor Author

@akashdhruv -- there have been more changes to the cmake stuff -- can you try again?

Ok.

@akashdhruv akashdhruv marked this pull request as ready for review October 23, 2024 22:57
@akashdhruv
Copy link
Contributor Author

akashdhruv commented Oct 23, 2024

This PR is ready for review and merge. Issues related to CMake have been resolved. To ensure that Noah MP interface is included as part of testing I recommend adding following cmake options to the test suite,

-DERF_ENABLE_NETCDF:BOOL=ON -DNETCDF_DIR=$NETCDF_HOME -DERF_ENABLE_NOAH:BOOL=ON

Note that using NOAH-MP requires building the Fortran interface for NetCDF. You can find build options for those in shell scripts located here: https://github.com/Lab-Notebooks/ERF-Noah-Coupling/tree/main/software/netcdf

@AMLattanzi AMLattanzi merged commit 4cd3ddd into erf-model:development Oct 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants