Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1D output for thetav #2015

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

AMLattanzi
Copy link
Collaborator

The Write1dProfiles had a bug in it related to the Thetav computation. I've included in the liquid water q_l = q_c + q_r; however, different sources have this as only q_c. The Bomex case with development was used to identify this bug:
image

@AMLattanzi AMLattanzi requested a review from ewquon December 9, 2024 18:59
@AMLattanzi AMLattanzi merged commit add69a0 into erf-model:development Dec 9, 2024
12 checks passed
@AMLattanzi AMLattanzi deleted the ProfileOutFix branch December 9, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant