Display non-field errors

- Updated the templates for the login, signup, and password reset pages to include non-field errors. - Escaped error messages to prevent potential security vulnerabilities.
erfanghorbanee · Sep 4, 2024 · 85edac1 · 85edac1
1 parent d665978
commit 85edac1
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 9 deletions.
diff --git a/Django-Shop/templates/account/login.html b/Django-Shop/templates/account/login.html
@@ -26,6 +26,13 @@
             <div class="login-form-container">
                 <h1 class="mb-4 text-center">Sign in</h1>
 
+                <!-- Display non-field errors -->
+                {% for error in form.non_field_errors %}
+                    <div class="text-danger">
+                        <p>{{ error|escape }}</p>
+                    </div>
+                {% endfor %}
+
                 {% if not SOCIALACCOUNT_ONLY %}
                     <form method="post" action="{% url 'account_login' %}" class="login-form">
                         {% csrf_token %}
@@ -35,7 +42,7 @@ <h1 class="mb-4 text-center">Sign in</h1>
                             {% if form.login.errors %}
                                 <div class="text-danger">
                                     {% for error in form.login.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}
@@ -46,7 +53,7 @@ <h1 class="mb-4 text-center">Sign in</h1>
                             {% if form.password.errors %}
                                 <div class="text-danger">
                                     {% for error in form.password.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}

diff --git a/Django-Shop/templates/account/password_reset.html b/Django-Shop/templates/account/password_reset.html
@@ -25,6 +25,14 @@
         <div class="col-md-6 d-flex align-items-center justify-content-center">
             <div class="reset-password-form-container">
                 <h1 class="mb-4">Password Reset</h1>
+
+                <!-- Display non-field errors -->
+                {% for error in form.non_field_errors %}
+                    <div class="text-danger">
+                        <p>{{ error|escape }}</p>
+                    </div>
+                {% endfor %}
+
                 {% if user.is_authenticated %}
                     <div class="alert alert-info">
                         You are already logged in. If you need to reset your password, please log out first.
@@ -41,7 +49,7 @@ <h1 class="mb-4">Password Reset</h1>
                             {% if form.email.errors %}
                                 <div class="text-danger">
                                     {% for error in form.email.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}

diff --git a/Django-Shop/templates/account/password_reset_from_key.html b/Django-Shop/templates/account/password_reset_from_key.html
@@ -31,6 +31,14 @@ <h1 class="mb-4">
                         Change Password
                     {% endif %}
                 </h1>
+
+                <!-- Display non-field errors -->
+                {% for error in form.non_field_errors %}
+                    <div class="text-danger">
+                        <p>{{ error|escape }}</p>
+                    </div>
+                {% endfor %}
+
                 {% if token_fail %}
                     {% url 'account_reset_password' as passwd_reset_url %}
                     <p class="mb-4">
@@ -47,7 +55,7 @@ <h1 class="mb-4">
                             {% if form.password1.errors %}
                                 <div class="text-danger">
                                     {% for error in form.password1.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}
@@ -58,7 +66,7 @@ <h1 class="mb-4">
                             {% if form.password2.errors %}
                                 <div class="text-danger">
                                     {% for error in form.password2.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}

diff --git a/Django-Shop/templates/account/signup.html b/Django-Shop/templates/account/signup.html
@@ -26,6 +26,13 @@
             <div class="signup-form-container">
                 <h1 class="mb-4 text-center">Sign up</h1>
 
+                <!-- Display non-field errors -->
+                {% for error in form.non_field_errors %}
+                    <div class="text-danger">
+                        <p>{{ error|escape }}</p>
+                    </div>
+                {% endfor %}
+
                 {% if not SOCIALACCOUNT_ONLY %}
                     <form method="post" action="{% url 'account_signup' %}" class="signup-form">
                         {% csrf_token %}
@@ -36,7 +43,7 @@ <h1 class="mb-4 text-center">Sign up</h1>
                             {% if form.email.errors %}
                                 <div class="text-danger">
                                     {% for error in form.email.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}
@@ -51,7 +58,7 @@ <h1 class="mb-4 text-center">Sign up</h1>
                             {% if form.phone.errors %}
                                 <div class="text-danger">
                                     {% for error in form.phone.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}
@@ -64,7 +71,7 @@ <h1 class="mb-4 text-center">Sign up</h1>
                             {% if form.password1.errors %}
                                 <div class="text-danger">
                                     {% for error in form.password1.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}
@@ -77,7 +84,7 @@ <h1 class="mb-4 text-center">Sign up</h1>
                             {% if form.password2.errors %}
                                 <div class="text-danger">
                                     {% for error in form.password2.errors %}
-                                        <p>{{ error }}</p>
+                                        <p>{{ error|escape }}</p>
                                     {% endfor %}
                                 </div>
                             {% endif %}