Fix: use getter for canvas property on Quagga object, 0.0.21

- also add test for canvas properties
ericblade · Apr 26, 2020 · 2ea50c4 · 2ea50c4
1 parent ee70a74
commit 2ea50c4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ericblade/quagga2",
-  "version": "0.0.20",
+  "version": "0.0.21",
   "description": "An advanced barcode-scanner written in JavaScript",
   "main": "lib/quagga.js",
   "types": "type-definitions/quagga.d.ts",

diff --git a/src/quagga.js b/src/quagga.js
@@ -290,7 +290,9 @@ export default {
             _context.resultCollector = resultCollector;
         }
     },
-    canvas: _context.canvasContainer,
+    get canvas() {
+        return _context.canvasContainer;
+    },
     decodeSingle: function (config, resultCallback) {
         if (this.inDecodeSingle) {
             // force multiple calls to decodeSingle to run in serial, because presently

diff --git a/test/integration/integration.spec.js b/test/integration/integration.spec.js
@@ -61,6 +61,14 @@ describe('decodeSingle', function () {
                     expect(result.codeResult.code).to.equal(sample.result);
                     console.warn(`* Expect ${result.codeResult.format} to equal ${sample.format}`);
                     expect(result.codeResult.format).to.equal(sample.format);
+                    console.warn(`* Expect Quagga.canvas to be an object ${Quagga.canvas}`);
+                    expect(Quagga.canvas).to.be.an('Object');
+                    console.warn(`* Expect Quagga.canvas.dom to be an object ${Quagga.canvas.dom}`);
+                    expect(Quagga.canvas.dom).to.be.an('Object');
+                    console.warn(`* Expect Quagga.canvas.ctx to be an object ${Quagga.canvas.ctx}`);
+                    expect(Quagga.canvas.ctx).to.be.an('Object');
+                    console.warn(`* Expect Quagga.canvas.ctx.overlay to be a CanvasRenderingContext2D ${Quagga.canvas.ctx.overlay}`);
+                    expect(Quagga.canvas.ctx.overlay).to.be.an('CanvasRenderingContext2D');
                     callback();
                 });
             }, function() {
@@ -120,7 +128,7 @@ describe('decodeSingle', function () {
 
     // TODO: write a test that tests Promise return/resolve
 
-    describe('EAN', function() {
+    describe.only('EAN', function() {
         var config = generateConfig(),
             testSet = [
                 {'name': 'image-001.jpg', 'result': '3574660239843'},