Merge pull request #462 from ericblade/dev

begin running tests in node 19.x
ericblade · Oct 19, 2022 · b003fbd · b003fbd
2 parents ef7511f + 6af572b
commit b003fbd
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 12 deletions.
diff --git a/.github/workflows/test-pr-legacy.yml b/.github/workflows/test-pr-legacy.yml
@@ -0,0 +1,44 @@
+name: Test Pull Requests To Master (Node pre-17)
+
+on:
+  push:
+    branches:
+      - greenkeeper/*
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [14.x, 16.x] # NOTE: When removing 14.x, we should be able to remove the 'upgrade npm' step!!!
+        os: [ubuntu-latest, windows-latest, macOS-latest]
+    steps:
+    - uses: actions/checkout@v1
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - name: upgrade npm
+      run: npm install -g npm
+    - name: npm versions
+      run: |
+        node --version
+        npm --version
+    - name: ci install
+      run: npm ci
+    - name: build
+      run: npm run build --if-present
+    - name: module test
+      run: npm run test:module
+    - name: run all code tests
+      run: npm test
+    - name: test package import
+      run: |
+        npm install ts-node @std/esm
+        npm run test:import
+    - name: test package require
+      run: |
+        npm run test:require
diff --git a/.github/workflows/test-pr.yml b/.github/workflows/test-pr.yml
@@ -1,4 +1,4 @@
-name: Test Pull Requests To Master
+name: Test Pull Requests To Master (Node 17.0+)
 
 on:
   push:
@@ -13,16 +13,14 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x] # NOTE: When removing 14.x, we should be able to remove the 'upgrade npm' step!!!
+        node-version: [18.x, 19.x]
         os: [ubuntu-latest, windows-latest, macOS-latest]
     steps:
     - uses: actions/checkout@v1
     - name: Use Node.js ${{ matrix.node-version }}
       uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node-version }}
-    - name: upgrade npm
-      run: npm install -g npm
     - name: npm versions
       run: |
         node --version
@@ -31,15 +29,17 @@ jobs:
       run: npm ci
     - name: build
       run: npm run build --if-present
-      NODE_OPTIONS: --openssl-legacy-provider
+      env:
+        CI: true
+        NODE_OPTIONS: --openssl-legacy-provider # necessary for webpack v4 in node 17+
     - name: module test
       run: npm run test:module
     - name: run all code tests
       run: npm test
-    # - name: test package import
-    #   run: |
-    #     npm install ts-node @std/esm
-    #     npm run test:import
-    # - name: test package require
-    #   run: |
-    #     npm run test:require
+    - name: test package import
+      run: |
+        npm install ts-node @std/esm
+        npm run test:import
+    - name: test package require
+      run: |
+        npm run test:require