Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join directive #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

colophonemes
Copy link

Fix error thrown by using 'join' as a method of the metalsmith object, rather than as an object itself

Fix error thrown by using 'join' as a method of the metalsmith object, rather than as an object itself
@ericgj
Copy link
Owner

ericgj commented Jun 24, 2016

Thanks. The underlying issue is this thing was never updated from pre-1.0.0 metalsmith... I'm surprised it still works at all!

It looks like the API was changed from metalsmith.join to metalsmith.path in v1.0.0. It would be better to use that rather than straight path.join since it looks like metalsmith.path prepends the metalsmith working directory.

But that would mean testing it on a newer version of metalsmith and updating package.json. Would you be up for doing that? I'm afraid I don't use metalsmith much anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants