Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Consolidate rather than jade #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

colophonemes
Copy link

I've refactored to use Consolidate.js. The plugin now takes an engine and ext parameter (defaulting to jade and .jade respectively.

This is important for my use case, because it means I can use the same version of Jade/Pug for both metalsmith-shortcodes and metalsmith-layouts, but presumably this is useful for those using different templating languages.

This also shifts Jade to devDependencies (so the tests still run), so if you're using this in another project you need to ensure you've got the engine installed

@ericgj
Copy link
Owner

ericgj commented Sep 10, 2016

Thanks for these updates. Since consolidate has an async interface, I think it makes more sense to use promises instead of async.each and a hacky workaround in the consolidate callback. (Arguably it would have been better to use promises from the beginning, but I wasn't as familiar with them at the time). Not sure when I'll have time to do that, but feel free to give it a shot if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants