-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Move turbo/trie and core/types/accounts to erigon-lib (#… #12903
Conversation
To test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be easier just to fix the RLP issue instead of reverting this?
I need this commit btw, otherwise I'm stuck on my work. |
You can always fork out, fix and raise a PR again. You must confirm, check and possibly fix the issue first. |
It's a big change, I am unable to provide a quick fix, so if you can confirm the issue yourself, please approve @antonis19 |
@somnathb1 but all I did was move the rlp package to |
It's not about easy and hard, |
Seems like this revert PR does fix the whole kurtosis run - https://github.com/erigontech/erigon/actions/runs/12068690419 |
…#12879)"
This reverts commit bc03aef.
Has to be reverted due to RLP decoding related issue in ForkchoicUpdate and MiningLoop