Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move turbo/trie and core/types/accounts to erigon-lib (#… #12903

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

somnathb1
Copy link
Contributor

#12879)"

This reverts commit bc03aef.

Has to be reverted due to RLP decoding related issue in ForkchoicUpdate and MiningLoop

@somnathb1
Copy link
Contributor Author

To test

kurtosis run --enclave my-testnet github.com/ethpandaops/ethereum-package --args-file .github/workflows/kurtosis/pectra.io

Copy link
Member

@antonis19 antonis19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be easier just to fix the RLP issue instead of reverting this?

@antonis19
Copy link
Member

I need this commit btw, otherwise I'm stuck on my work.

@somnathb1
Copy link
Contributor Author

I need this commit btw, otherwise I'm stuck on my work.

You can always fork out, fix and raise a PR again. You must confirm, check and possibly fix the issue first.

@somnathb1
Copy link
Contributor Author

It's a big change, I am unable to provide a quick fix, so if you can confirm the issue yourself, please approve @antonis19

@antonis19
Copy link
Member

@somnathb1 but all I did was move the rlp package toerigon-lib, there's gotta be an easier to fix it.

@somnathb1
Copy link
Contributor Author

It's not about easy and hard, main is potentially broken at the moment. The referenced commit seems to be the culprit for the RLP-related issue. This PR simply points it out. Please confirm if you have identified the issue.
You can always fork out. @antonis19

@somnathb1
Copy link
Contributor Author

Seems like this revert PR does fix the whole kurtosis run - https://github.com/erigontech/erigon/actions/runs/12068690419

@somnathb1 somnathb1 merged commit cd418eb into main Nov 28, 2024
14 of 16 checks passed
@somnathb1 somnathb1 deleted the som/fix_kurtosis_td_revert branch November 28, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants