FirstDup support (#99)

erigontech · Mar 8, 2023 · 12532c9 · 12532c9
1 parent eda876f
commit 12532c9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/mdbx/cursor.go b/mdbx/cursor.go
@@ -168,7 +168,7 @@ func (c *Cursor) Get(setkey, setval []byte, op uint) (key, val []byte, err error
 	if op == Set {
 		key = setkey
 	} else {
-		if op != LastDup {
+		if op != LastDup && op != FirstDup {
 			key = castToBytes(c.txn.key)
 		}
 	}

diff --git a/mdbx/cursor_test.go b/mdbx/cursor_test.go
@@ -316,16 +316,29 @@ func TestLastDup(t *testing.T) {
 				return err
 			}
 			i++
+
 			_, v, err := c.Get(nil, nil, LastDup)
 			if err != nil {
 				return err
 			}
 			if i == 1 && string(v) != "value1.3" {
-				t.Fail()
+				panic(1)
 			}
 			if i == 2 && string(v) != "value3.3" {
-				t.Fail()
+				panic(1)
+			}
+
+			_, v, err = c.Get(nil, nil, FirstDup)
+			if err != nil {
+				return err
+			}
+			if i == 1 && string(v) != "value1.1" {
+				panic(1)
 			}
+			if i == 2 && string(v) != "value3.1" {
+				panic(1)
+			}
+
 		}
 
 		return nil