mdbx_version description string - e2 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2024
AskAlexSharov
requested changes
Jan 9, 2024
mdbx/cursor.go
Outdated
| @@ -168,7 +170,7 @@ func (c *Cursor) Get(setkey, setval []byte, op uint) (key, val []byte, err error | |||
| if op == Set { | |||
| key = setkey | |||
| } else { | |||
| if op != LastDup { | |||
| if op != LastDup && op != FirstDup { | |||
There was a problem hiding this comment.
FYI: we have 2 versions - Erigon2 (devel) using version v0.27.21(mdbx-go branch v0_27), Erigon3 (e35) using version v0.37.0(mdbx-go branch master).
You will need open same PR into v0_27 branch also.
There was a problem hiding this comment.
don't really understand why you have merge conflicts. likely you choose wrong "target branch" for pr?
There was a problem hiding this comment.
@AskAlexSharov thanks, you've predicted my question :)
battlmonstr
force-pushed
the
pr/libmdbx_version
branch
from
56f9f1c to
8a3ea46
Compare
battlmonstr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.