Key non pointer opt #143

JkLondon · 2024-06-13T07:45:22Z

goarch: amd64
pkg: github.com/erigontech/mdbx-go/mdbx
cpu: 12th Gen Intel(R) Core(TM) i7-12700H
                        │ txn_key_pointer.txt │       txn_key_non_pointer.txt        │
                        │       sec/op        │    sec/op     vs base                │
Cursor-20                         169.8n ± 2%   168.2n ±  1%        ~ (p=0.092 n=10)
Cursor_Renew/1-20                 57.66n ± 3%   57.40n ±  5%        ~ (p=0.895 n=10)
Cursor_Renew/2-20                 55.76n ± 2%   55.95n ±  3%        ~ (p=0.225 n=10)
Cursor_Renew/3-20                 167.4n ± 4%   167.5n ±  1%        ~ (p=0.927 n=10)
Cursor_Renew/4-20                 61.62n ± 5%   61.87n ±  4%        ~ (p=0.481 n=10)
Cursor_SetRange-20                89.00n ± 3%   76.91n ±  2%  -13.59% (p=0.000 n=10)
Errno_Error-20                    364.7n ± 7%   348.7n ± 10%        ~ (p=0.165 n=10)
Txn_abort-20                      217.7n ± 2%   220.7n ±  5%        ~ (p=0.066 n=10)
Txn_ro-20                         433.4n ± 6%   428.3n ±  6%        ~ (p=0.579 n=10)
Txn_unmanaged_abort-20            191.6n ± 4%   201.3n ±  3%   +5.09% (p=0.001 n=10)
Txn_unmanaged_commit-20           197.4n ± 3%   203.3n ±  3%   +2.99% (p=0.001 n=10)
Txn_unmanaged_ro-20               281.8n ± 2%   261.6n ±  3%   -7.19% (p=0.000 n=10)
Txn_renew-20                      118.9n ± 4%   114.4n ±  3%   -3.78% (p=0.037 n=10)
Txn_Get-20                        72.98n ± 4%   72.21n ±  1%   -1.06% (p=0.015 n=10)
geomean                           143.7n        141.2n         -1.70%

AskAlexSharov · 2024-06-13T08:55:25Z

mdbx/txn.go

@@ -92,13 +92,13 @@ func beginTxn(env *Env, parent *Txn, flags uint) (*Txn, error) {
 		if flags&Readonly == 0 {
 			// In a write Txn we can use the shared, C-allocated key and value
 			// allocated by env, and freed when it is closed.
-			txn.key = env.ckey
+			txn.key = *env.ckey


don't need this line anymore

AskAlexSharov · 2024-06-13T08:55:36Z

mdbx/txn.go

 		} else {
 			// It is not easy to share C.MDBX_val values in this scenario unless
 			// there is a synchronized pool involved, which will increase
 			// overhead.  Further, allocating these values with C will add
 			// overhead both here and when the values are freed.
-			txn.key = new(C.MDBX_val)
+			txn.key = C.MDBX_val{}


don't need this line anymore

txn.key = parent.key also

Ilya Miheev added 2 commits June 13, 2024 11:08

changed to non-pointer with key

2e546e3

changed cgosymbolizer

5a5b79c

AskAlexSharov merged commit 39eccf6 into master Jun 13, 2024
4 of 5 checks passed

AskAlexSharov reviewed Jun 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Key non pointer opt #143

Key non pointer opt #143

JkLondon commented Jun 13, 2024

AskAlexSharov Jun 13, 2024

AskAlexSharov Jun 13, 2024

AskAlexSharov Jun 13, 2024

JkLondon Jun 13, 2024

Key non pointer opt #143

Key non pointer opt #143

Conversation

JkLondon commented Jun 13, 2024

AskAlexSharov Jun 13, 2024

Choose a reason for hiding this comment

AskAlexSharov Jun 13, 2024

Choose a reason for hiding this comment

AskAlexSharov Jun 13, 2024

Choose a reason for hiding this comment

JkLondon Jun 13, 2024

Choose a reason for hiding this comment