build(deps): bump xunit from 2.5.3 to 2.6.3 (#412)

* build(deps): bump xunit from 2.5.3 to 2.6.3 Bumps [xunit](https://github.com/xunit/xunit) from 2.5.3 to 2.6.3. - [Commits](xunit/xunit@2.5.3...2.6.3) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Nullability in unit tests fixes --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik A. Brandstadmoen <[email protected]>
erikbra · Dec 18, 2023 · fc23c58 · fc23c58
1 parent 81277c7
commit fc23c58
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 36 deletions.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -25,7 +25,7 @@
       Note: the following references are exclusively used in the test projects:
     -->
     <PackageVersion Include="Microsoft.NET.Test.Sdk"                                                     Version="17.8.0" />
-    <PackageVersion Include="xunit"                                                                      Version="2.5.3" />
+    <PackageVersion Include="xunit"                                                                      Version="2.6.3" />
     <PackageVersion Include="xunit.runner.visualstudio"                                                  Version="2.5.5" />
     <PackageVersion Include="FluentAssertions"                                                           Version="6.12.0" />
     <PackageVersion Include="NSubstitute"                                                                Version="5.1.0" />

diff --git a/unittests/Basic_tests/CommandLineParsing/FolderConfiguration_.cs b/unittests/Basic_tests/CommandLineParsing/FolderConfiguration_.cs
@@ -48,11 +48,11 @@ public async Task Fully_Customised(string name, string root, string foldersArgum
         AssertEquivalent(expected.Values, actual?.Values);
     }
 
-    public static TheoryData<string, KnownFolderNames?> FoldersCommandLines() =>
+    public static TheoryData<string, KnownFolderNames> FoldersCommandLines() =>
         new()
         {
-            { "--folders=up=tables", Wrap(KnownFolderNames.Default with { Up = "tables" }) },
-            { "--folders=up=tables;views=projections", Wrap(KnownFolderNames.Default with { Up = "tables", Views = "projections" }) },
+            { "--folders=up=tables", Wrap(KnownFolderNames.Default with { Up = "tables" })! },
+            { "--folders=up=tables;views=projections", Wrap(KnownFolderNames.Default with { Up = "tables", Views = "projections" })! },
         };
 
 

diff --git a/unittests/Basic_tests/Infrastructure/FolderConfiguration/KnownFolders_CustomNames.cs b/unittests/Basic_tests/Infrastructure/FolderConfiguration/KnownFolders_CustomNames.cs
@@ -82,24 +82,24 @@ TransactionHandling tran
     private static readonly DirectoryInfo Root = TestConfig.CreateRandomTempDirectory();
     private static readonly IFoldersConfiguration Folders = FoldersConfiguration.Default(OverriddenFolderNames);
 
-    public static TheoryData<MigrationsFolderWithDescription?, string, MigrationType, ConnectionType, TransactionHandling> ExpectedKnownFolderNames()
+    public static TheoryData<MigrationsFolderWithDescription, string, MigrationType, ConnectionType, TransactionHandling> ExpectedKnownFolderNames()
     {
-        var data = new TheoryData<MigrationsFolderWithDescription?, string, MigrationType, ConnectionType, TransactionHandling>
+        var data = new TheoryData<MigrationsFolderWithDescription, string, MigrationType, ConnectionType, TransactionHandling>
         {
-            { Describe(Folders[BeforeMigration]), OverriddenFolderNames.BeforeMigration, EveryTime, Default, TransactionHandling.Autonomous },
-            { Describe(Folders[AlterDatabase]), OverriddenFolderNames.AlterDatabase, AnyTime, Admin, TransactionHandling.Autonomous },
-            { Describe(Folders[RunAfterCreateDatabase]), OverriddenFolderNames.RunAfterCreateDatabase, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[RunBeforeUp]), OverriddenFolderNames.RunBeforeUp, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[Up]), OverriddenFolderNames.Up, Once, Default, TransactionHandling.Default },
-            { Describe(Folders[RunFirstAfterUp]), OverriddenFolderNames.RunFirstAfterUp, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[Functions]), OverriddenFolderNames.Functions, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[Views]), OverriddenFolderNames.Views, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[Sprocs]), OverriddenFolderNames.Sprocs, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[Triggers]), OverriddenFolderNames.Triggers, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[Indexes]), OverriddenFolderNames.Indexes, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[RunAfterOtherAnyTimeScripts]), OverriddenFolderNames.RunAfterOtherAnyTimeScripts, AnyTime, Default, TransactionHandling.Default },
-            { Describe(Folders[Permissions]), OverriddenFolderNames.Permissions, EveryTime, Default, TransactionHandling.Autonomous },
-            { Describe(Folders[AfterMigration]), OverriddenFolderNames.AfterMigration, EveryTime, Default, TransactionHandling.Autonomous }
+            { Describe(Folders[BeforeMigration])!, OverriddenFolderNames.BeforeMigration, EveryTime, Default, TransactionHandling.Autonomous },
+            { Describe(Folders[AlterDatabase])!, OverriddenFolderNames.AlterDatabase, AnyTime, Admin, TransactionHandling.Autonomous },
+            { Describe(Folders[RunAfterCreateDatabase])!, OverriddenFolderNames.RunAfterCreateDatabase, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[RunBeforeUp])!, OverriddenFolderNames.RunBeforeUp, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[Up])!, OverriddenFolderNames.Up, Once, Default, TransactionHandling.Default },
+            { Describe(Folders[RunFirstAfterUp])!, OverriddenFolderNames.RunFirstAfterUp, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[Functions])!, OverriddenFolderNames.Functions, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[Views])!, OverriddenFolderNames.Views, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[Sprocs])!, OverriddenFolderNames.Sprocs, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[Triggers])!, OverriddenFolderNames.Triggers, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[Indexes])!, OverriddenFolderNames.Indexes, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[RunAfterOtherAnyTimeScripts])!, OverriddenFolderNames.RunAfterOtherAnyTimeScripts, AnyTime, Default, TransactionHandling.Default },
+            { Describe(Folders[Permissions])!, OverriddenFolderNames.Permissions, EveryTime, Default, TransactionHandling.Autonomous },
+            { Describe(Folders[AfterMigration])!, OverriddenFolderNames.AfterMigration, EveryTime, Default, TransactionHandling.Autonomous }
        };
        return data;
     }

diff --git a/unittests/TestCommon/Generic/Running_MigrationScripts/Failing_Scripts.cs b/unittests/TestCommon/Generic/Running_MigrationScripts/Failing_Scripts.cs
@@ -287,28 +287,28 @@ protected void CreateLongInvalidSql(DirectoryInfo root, MigrationsFolder? folder
     //private static readonly DirectoryInfo Root = TestConfig.CreateRandomTempDirectory();
     private static readonly IFoldersConfiguration Folders = FoldersConfiguration.Default(null);
 
-    public static TheoryData<MigrationsFolderWithDescription?> ShouldStillBeRunOnRollback() =>
+    public static TheoryData<MigrationsFolderWithDescription> ShouldStillBeRunOnRollback() =>
         new()
         {
-            { Describe(Folders[BeforeMigration]) },
-            { Describe(Folders[AlterDatabase]) },
-            { Describe(Folders[Permissions]) },
-            { Describe(Folders[AfterMigration]) }
+            { Describe(Folders[BeforeMigration])! },
+            { Describe(Folders[AlterDatabase])! },
+            { Describe(Folders[Permissions])! },
+            { Describe(Folders[AfterMigration])! }
         };
 
-    public static TheoryData<MigrationsFolderWithDescription?> ShouldNotBeRunOnRollback() =>
+    public static TheoryData<MigrationsFolderWithDescription> ShouldNotBeRunOnRollback() =>
         new()
         {
-            { Describe(Folders[RunAfterCreateDatabase]) },
-            { Describe(Folders[RunBeforeUp]) },
-            { Describe(Folders[Up]) },
-            { Describe(Folders[RunFirstAfterUp]) },
-            { Describe(Folders[Functions]) },
-            { Describe(Folders[Views]) },
-            { Describe(Folders[Sprocs]) },
-            { Describe(Folders[Triggers]) },
-            { Describe(Folders[Indexes]) },
-            { Describe(Folders[RunAfterOtherAnyTimeScripts]) }
+            { Describe(Folders[RunAfterCreateDatabase])! },
+            { Describe(Folders[RunBeforeUp])! },
+            { Describe(Folders[Up])! },
+            { Describe(Folders[RunFirstAfterUp])! },
+            { Describe(Folders[Functions])! },
+            { Describe(Folders[Views])! },
+            { Describe(Folders[Sprocs])! },
+            { Describe(Folders[Triggers])! },
+            { Describe(Folders[Indexes])! },
+            { Describe(Folders[RunAfterOtherAnyTimeScripts])! }
         };
 
 }