-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test with testcontainers #405
Unit test with testcontainers #405
Conversation
- Centrally nuget package - Add rule check
Hi, @hoangthanh28. Thanks a lot for your PR! Great that you love great (pun intended), and even better that you would like to contribute! This is what open source should be, collaboration! :) I originally used NUnit for grate, partly because it was used in RoundhousE, and partly because the "run this thing once before all tests" was easier in NUnit, at least I thought so at the time. So I used that for setting up the containers before running the tests. But I like xUnit better personally as well. Your PR is quite big, so I'll have to take a little while looking into it, but initially I'm positive to the initiatives! |
Thank you Erik for your consideration. Btw, I'm a 5-year RoundHousE user, as well as a big fan of database first, changing database is crucial, so we need to script it down and put into the version control system. :) |
Thanks again, @hoangthanh28 - I have looked through it, and it looks very clean and good quality code, I like it! I'm going to merge this as-is. I have a few suggestions for improvements, but I'll just make a separate PR myself into main for them. |
Hi Erik.
I plan to contribute to grate because I love it. It's a great tool, please consider my PR with the following changes: