Chore: Making the public API interface of grate more maintainable beore exposing as a nuget package #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore exposing as a nuget package When exposing grate as a nuget package, all of the source code is effectively a "user interface", as opposed to when we only publish the command line artifact, where the command line is the only user interface. We don't want a huge API interface that users start to use and rely on, that we have to keep stable, so I narrowed down the number of public types significantly (hope I didn't go too far). In addition, I changed the unit tests to use the DI builders, so that we know that we support a lot of common usage scenarios (which I hope the unit tests represent). Some highlights: * Use TryAddTransient and ..Singleton to avoid concurrency issues in dependency registration * Removed ServiceCollection from GrateConfgurationBuilder * Rewrote unit tests to use dependency injection - getting a feel on how it is to use
erikbra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exposing grate as a nuget package, all of the source code is effectively a "user interface", as opposed to when we only publish the command line artifact, where the command line is the only user interface.
We don't want a huge API interface that users start to use and rely on, that we have to keep stable, so I narrowed down the number of public types significantly (hope I didn't go too far).
In addition, I changed the unit tests to use the DI builders, so that we know that we support a lot of common usage scenarios (which I hope the unit tests represent).
Some highlights: