Merge pull request #511 from erikdarlingdata/dev

Dev

Alerts/Alerts.sql

@@ -11,7 +11,7 @@ GO
 
 This script will set up alerts for high severity and corruption errors in SQL Server.
 
-Copyright 2024 Darling Data, LLC
+Copyright 2025 Darling Data, LLC
 https://www.erikdarling.com/
 
 For support, head over to GitHub:
@@ -53,7 +53,7 @@ DECLARE
 
 RETURN;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Severity 019',
     @message_id = 0,
     @severity = 19,
@@ -62,12 +62,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Severity 019',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Severity 020',
     @message_id = 0,
     @severity = 20,
@@ -76,12 +76,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Severity 020',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Severity 021',
     @message_id = 0,
     @severity = 21,
@@ -90,12 +90,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Severity 021',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Severity 022',
     @message_id = 0,
     @severity = 22,
@@ -104,12 +104,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Severity 022',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Severity 023',
     @message_id = 0,
     @severity = 23,
@@ -118,12 +118,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Severity 023',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Severity 024',
     @message_id = 0,
     @severity = 24,
@@ -132,12 +132,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Severity 024',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Severity 025',
     @message_id = 0,
     @severity = 25,
@@ -146,12 +146,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Severity 025',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Error Number 823',
     @message_id = 823,
     @severity = 0,
@@ -160,12 +160,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Error Number 823',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Error Number 824',
     @message_id = 824,
     @severity = 0,
@@ -174,12 +174,12 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Error Number 824',
     @operator_name = @operator_name,
     @notification_method = 7;
 
-EXEC msdb.dbo.sp_add_alert
+EXECUTE msdb.dbo.sp_add_alert
     @name = N'Error Number 825',
     @message_id = 825,
     @severity = 0,
@@ -188,7 +188,7 @@ EXEC msdb.dbo.sp_add_alert
     @include_event_description_in = 1,
     @job_id = N'00000000-0000-0000-0000-000000000000';
 
-EXEC msdb.dbo.sp_add_notification
+EXECUTE msdb.dbo.sp_add_notification
     @alert_name = N'Error Number 825',
     @operator_name = @operator_name,
     @notification_method = 7;

Clear Token Perm/ClearTokenPerm Agent Job.sql

@@ -16,7 +16,7 @@ For background on why you might need this:
 
 In short, if your security caches are growing out of control, it can cause all sorts of weird issues with SQL Server.
 
-Copyright 2024 Darling Data, LLC
+Copyright 2025 Darling Data, LLC
 https://www.erikdarling.com/
 
 For support, head over to GitHub:
@@ -52,7 +52,7 @@ IF NOT EXISTS
     AND   category_class = 1
 )
 BEGIN
-    EXEC @ReturnCode = msdb.dbo.sp_add_category
+    EXECUTE @ReturnCode = msdb.dbo.sp_add_category
         @class = N'JOB',
         @type = N'LOCAL',
         @name = N'[Uncategorized (Local)]';
@@ -62,7 +62,7 @@ BEGIN
 END;
 
 
-EXEC @ReturnCode = msdb.dbo.sp_add_job
+EXECUTE @ReturnCode = msdb.dbo.sp_add_job
     @job_name = N'Clear Security Cache Every 30 Minutes',
     @enabled = 1,
     @notify_level_eventlog = 0,
@@ -85,7 +85,7 @@ https://github.com/erikdarlingdata/DarlingData',
 IF (@@ERROR <> 0 OR @ReturnCode <> 0)
     GOTO QuitWithRollback;
 
-EXEC @ReturnCode = msdb.dbo.sp_add_jobstep
+EXECUTE @ReturnCode = msdb.dbo.sp_add_jobstep
     @job_id = @jobId,
     @step_name = N'Execute dbo.ClearTokenPerm',
     @step_id = 1,
@@ -98,22 +98,22 @@ EXEC @ReturnCode = msdb.dbo.sp_add_jobstep
     @retry_interval = 0,
     @os_run_priority = 0,
     @subsystem = N'TSQL',
-    @command = N'EXEC dbo.ClearTokenPerm
+    @command = N'EXECUTE dbo.ClearTokenPerm
     @CacheSizeGB = 1;',
     @database_name = N'master',
     @flags = 0;
 
 IF (@@ERROR <> 0 OR @ReturnCode <> 0)
     GOTO QuitWithRollback;
 
-EXEC @ReturnCode = msdb.dbo.sp_update_job
+EXECUTE @ReturnCode = msdb.dbo.sp_update_job
     @job_id = @jobId,
     @start_step_id = 1;
 
 IF (@@ERROR <> 0 OR @ReturnCode <> 0)
     GOTO QuitWithRollback;
 
-EXEC @ReturnCode = msdb.dbo.sp_add_jobschedule
+EXECUTE @ReturnCode = msdb.dbo.sp_add_jobschedule
     @job_id = @jobId,
     @name = N'Clear Security Cache Every 30 Minutes',
     @enabled = 1,
@@ -132,7 +132,7 @@ EXEC @ReturnCode = msdb.dbo.sp_add_jobschedule
 IF (@@ERROR <> 0 OR @ReturnCode <> 0)
     GOTO QuitWithRollback;
 
-EXEC @ReturnCode = msdb.dbo.sp_add_jobserver
+EXECUTE @ReturnCode = msdb.dbo.sp_add_jobserver
     @job_id =
     @jobId,
     @server_name = N'(local)';

Clear Token Perm/ClearTokenPerm.sql

@@ -16,7 +16,7 @@ For background on why you might need this:
 
 In short, if your security caches are growing out of control, it can cause all sorts of weird issues with SQL Server.
 
-Copyright 2024 Darling Data, LLC
+Copyright 2025 Darling Data, LLC
 https://www.erikdarling.com/
 
 For support, head over to GitHub:
@@ -48,7 +48,7 @@ SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 DECLARE
     @clear_triggered bit = 0;
 
-IF OBJECT_ID(N'dbo.ClearTokenPermLogging') IS NULL
+IF OBJECT_ID(N'dbo.ClearTokenPermLogging', N'U') IS NULL
 BEGIN
     CREATE TABLE
         dbo.ClearTokenPermLogging
@@ -70,8 +70,8 @@ IF
                 (domc.pages_kb / 1024. / 1024.)
             )
     FROM sys.dm_os_memory_clerks AS domc
-    WHERE domc.type = 'USERSTORE_TOKENPERM'
-    AND   domc.name = 'TokenAndPermUserStore'
+    WHERE domc.type = N'USERSTORE_TOKENPERM'
+    AND   domc.name = N'TokenAndPermUserStore'
 ) >= @CacheSizeGB
 BEGIN
     INSERT
@@ -93,8 +93,8 @@ BEGIN
         clear_triggered =
             1
     FROM sys.dm_os_memory_clerks AS domc
-    WHERE domc.type = 'USERSTORE_TOKENPERM'
-    AND   domc.name = 'TokenAndPermUserStore';
+    WHERE domc.type = N'USERSTORE_TOKENPERM'
+    AND   domc.name = N'TokenAndPermUserStore';
 
     DBCC FREESYSTEMCACHE('TokenAndPermUserStore');
 END;
@@ -119,14 +119,14 @@ BEGIN
         clear_triggered =
             0
     FROM sys.dm_os_memory_clerks AS domc
-    WHERE domc.type = 'USERSTORE_TOKENPERM'
-    AND   domc.name = 'TokenAndPermUserStore';
+    WHERE domc.type = N'USERSTORE_TOKENPERM'
+    AND   domc.name = N'TokenAndPermUserStore';
     END;
 END;
 RETURN;
 
 /*Example execution*/
-EXEC dbo.ClearTokenPerm
+EXECUTE dbo.ClearTokenPerm
     @CacheSizeGB = 1;
 
 /*Query a log*/

Clear Token Perm/Inflate Security Cache Demo And Analysis Script.sql

@@ -21,7 +21,7 @@ https://github.com/erikdarlingdata/DarlingData
 
 MIT License
 
-Copyright 2024 Darling Data, LLC
+Copyright 2025 Darling Data, LLC
 
 https://www.erikdarling.com/
 
@@ -71,7 +71,7 @@ END;
 
 WHILE @counter < 50000
 BEGIN
-    EXEC sys.sp_setapprole
+    EXECUTE sys.sp_setapprole
         @rolename = N'your_terrible_app',
         @password = N'y0ur_t3rr1bl3_4pp',
         @fCreateCookie = true,
@@ -80,7 +80,7 @@ BEGIN
     SELECT
         @bl0b_eater = USER_NAME();
 
-    EXEC sys.sp_unsetapprole
+    EXECUTE sys.sp_unsetapprole
         @cronut;
 
     SELECT
@@ -174,9 +174,9 @@ SELECT
     token_name =
         c.c.value('@name', 'varchar(50)'),
     principal_id =
-        c.c.value('@id', 'int'),
+        c.c.value('@id', 'integer'),
     database_id =
-        c.c.value('@dbid', 'int'),
+        c.c.value('@dbid', 'integer'),
     time_stamp =
         c.c.value('@timestamp', 'bigint')
 INTO #tapus
@@ -204,7 +204,7 @@ SELECT
 FROM #tapus AS t
 INNER JOIN sys.server_principals AS p
   ON t.principal_id = p.principal_id
-WHERE t.token_name = 'SecContextToken'
+WHERE t.token_name = N'SecContextToken'
 GROUP BY
     p.name
 ORDER BY
@@ -219,8 +219,8 @@ SELECT
 FROM #tapus AS t
 INNER JOIN sys.databases AS d
   ON d.database_id = t.database_id
-WHERE t.token_name = 'UserToken'
-AND   t.cache_name = 'TokenAndPermUserStore'
+WHERE t.token_name = N'UserToken'
+AND   t.cache_name = N'TokenAndPermUserStore'
 GROUP BY
     d.name
 ORDER BY
@@ -235,7 +235,7 @@ SELECT
 FROM #tapus AS t
 INNER JOIN sys.databases AS d
   ON d.database_id = t.database_id
-WHERE t.token_name = 'UserToken'
+WHERE t.token_name = N'UserToken'
 GROUP BY
     d.name
 ORDER BY

Create Long IN List/Longingly.sql

@@ -13,7 +13,7 @@ GO
 
 This procedure exists only to show how long IN clauses can hurt query performance.
 
-Copyright 2024 Darling Data, LLC
+Copyright 2025 Darling Data, LLC
 https://www.erikdarling.com/
 
 For support, head over to GitHub:

Dynamic SQL Logging/Dynamic SQL Logging.sql

@@ -13,7 +13,7 @@ GO
 
 Stored procedure to be used for logging performance information from dynamic SQL
 
-Copyright (c) 2024 Darling Data, LLC
+Copyright (c) 2025 Darling Data, LLC
 https://www.erikdarling.com/
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"),
@@ -32,7 +32,7 @@ USE OR OTHER DEALINGS IN THE SOFTWARE.
 CREATE OR ALTER PROCEDURE
     dbo.logging
 (
-    @spid int,
+    @spid integer,
     @sql nvarchar(MAX),
     @query_plan xml,
     @guid_in uniqueidentifier,