ssl: Convey alert information to passive socket operations recv and s… #8823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 67 suites 47m 57s ⏱️ Results for commit 6e08534. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
IngelaAndin
force-pushed
the
ingela/ssl/recv-setopts-alert/OTP-19236
branch
from
ebac4cc to
2f89b65
Compare
IngelaAndin
added
the
testing
u3s
approved these changes
Sep 23, 2024
IngelaAndin
force-pushed
the
ingela/ssl/recv-setopts-alert/OTP-19236
branch
from
2f89b65 to
5837926
Compare
…etopts If a TLS-1.3 server fails client certification the alert might arrive in the connection state and even after data has been sent. Make sure the alert information will be available in error reason returned from passive socket API functions recv and setopt.
IngelaAndin
force-pushed
the
ingela/ssl/recv-setopts-alert/OTP-19236
branch
from
5837926 to
6e08534
Compare
|
@IngelaAndin In the Gun ticket linked just above this comment a user points out that the TLS alert may be lost in additional cases such as when calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etopts
If a TLS-1.3 server fails client certification the alert might arrive in the connection state and even after data has been sent. Make sure the alert information will be available in error reason returned from passive socket API functions recv and setopt.