Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: fix callbacks_daemon_options() type spec #9188

Open
wants to merge 1 commit into
base: maint
Choose a base branch
from
Open

ssh: fix callbacks_daemon_options() type spec #9188

wants to merge 1 commit into from

Conversation

sg2342
Copy link
Contributor

@sg2342 sg2342 commented Dec 13, 2024

Fixes #9187

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

CT Test Results

    2 files     29 suites   18m 35s ⏱️
  464 tests   460 ✅  4 💤 0 ❌
1 669 runs  1 645 ✅ 24 💤 0 ❌

Results for commit 42eb8a3.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s u3s added the team:PS Assigned to OTP team PS label Dec 16, 2024
@u3s u3s self-assigned this Dec 16, 2024
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Dec 17, 2024
u3s
u3s previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase the branch to maint and adjust the target to maint as well?

@sg2342 sg2342 force-pushed the fix_ssh_callbacks_daemon_options_spec branch from 097c64b to 42eb8a3 Compare December 17, 2024 12:43
@sg2342 sg2342 changed the base branch from master to maint December 17, 2024 12:44
@sg2342
Copy link
Contributor Author

sg2342 commented Dec 17, 2024

can you rebase the branch to maint and adjust the target to maint as well?

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u3s u3s u3s left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@u3s u3s

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssh: wrong type callbacks_daemon_options()
2 participants
@sg2342 @u3s