Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: Add callback to retrieve saved keylog when connection fails #9221

Open
wants to merge 1 commit into
base: maint
Choose a base branch
from

Conversation

IngelaAndin
Copy link
Contributor

Keylogging debug functionality should be useable also for failed connections, this
is especially interesting for TLS-1.3.

@IngelaAndin IngelaAndin requested review from u3s and dgud December 19, 2024 13:55
Copy link
Contributor

github-actions bot commented Dec 19, 2024

CT Test Results

  1 files   11 suites   4m 6s ⏱️
 93 tests  91 ✅ 2 💤 0 ❌
109 runs  107 ✅ 2 💤 0 ❌

Results for commit 5c0fa17.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin self-assigned this Dec 19, 2024
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Dec 19, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/keep-secret-alert-cb/OTP-19391 branch 2 times, most recently from 9b63ea2 to 2471353 Compare December 20, 2024 10:53
u3s
u3s previously approved these changes Dec 23, 2024
lib/ssl/src/tls_server_connection_1_3.erl Outdated Show resolved Hide resolved
lib/ssl/test/ssl_api_SUITE.erl Show resolved Hide resolved
lib/ssl/test/ssl_api_SUITE.erl Show resolved Hide resolved
lib/ssl/test/tls_1_3_version_SUITE.erl Show resolved Hide resolved
lib/ssl/src/ssl.erl Outdated Show resolved Hide resolved
lib/ssl/src/ssl_gen_statem.erl Show resolved Hide resolved
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Dec 28, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/keep-secret-alert-cb/OTP-19391 branch from 2471353 to 0a9b377 Compare January 3, 2025 10:05
@IngelaAndin IngelaAndin requested a review from u3s January 3, 2025 10:07
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/keep-secret-alert-cb/OTP-19391 branch from 0a9b377 to 5c0fa17 Compare January 3, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants