Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Improve message completion #539

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nicolashohm
Copy link
Contributor

  • Disable browser autocomplete for message field
  • Add client setting to customize string to append after tab completion

Resolves: #297

* Disable browser autocomplete for message field
* Add client setting to customize string to append after tab completion

Resolves: erming#297
@jancborchardt
Copy link
Contributor

Adding a setting for something as minor as this is a bit overkill. Why not design it well and simply go with a space? That’s e.g. what IRCCloud does.

@jancborchardt
Copy link
Contributor

Also – thanks for the fix! :)

@polux
Copy link

polux commented Apr 26, 2016

@jancborchardt based on the discussions #297 I would guess that arbitrarily choosing space would be controversial. Someone asks for ": " and another person for ", ". Add " " to this and it's already three different proposals. I think leaving the choice to the user is a good thing. The IRC clients I've used (xchat and irssi) allow for this.

@polux
Copy link

polux commented Apr 26, 2016

@nickel715 you need to call initTabCompletion in on("init", ...) too.

@jancborchardt
Copy link
Contributor

Just making a proper design decision in this case is much better, and there needs to be a default anyway – the current default of doing nothing is the worst option of them all. The comparison with chat tools of the olden days like XChat and Irssi I would not recommend either. Look at Slack or Twitter or Facebook or Github instead – all of which follow the username with a simple space.

@jancborchardt
Copy link
Contributor

In any case, not sure if you noticed but Shout is now continued as Lounge at: https://github.com/thelounge/lounge/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants