Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Reconnection support and command/join order fix. #665

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bews
Copy link

@bews bews commented May 10, 2016

Based on code from #541.

Changes: exponential reconnection attempts fixed; added reconnect on ping timeout.

Every time reconnect happens, a message is posted to the main window:

2016-05-11_02-21-47

Issues: #658 #235 #395 #654

@bews bews changed the title Reconnection support. Reconnection support and command/join order fix. May 12, 2016
@bews
Copy link
Author

bews commented May 12, 2016

Added fix for #662 - it changes already modified code, so I committed it here.

Problem was in irc.once("pong", function() { - PING command is firing from somewhere else too (besides irc.write("PING " + network.host);) so this event happens before user commands are finished.

@bews
Copy link
Author

bews commented May 12, 2016

Merged all my additions in https://github.com/bews/shout/tree/bews-master - you can grab them from there till this is not merged.

@MaxLeiter
Copy link
Contributor

If it won't be merged, why not use TheLounge and contribute fixes for others to also use?

@bews
Copy link
Author

bews commented May 12, 2016

If it won't be merged, why not use TheLounge and contribute fixes for others to also use?

As I said in previous PR:

when I started working with Shout I didn't know about Lounge fork, so I'll stick with this one :)

I just upload changes I did some time ago and don't plan making anything more here.

TheLounge is basically the same atm, so I don't feel like moving to it now. Maybe later, when it will have DCC and ban lists :)

@astorije
Copy link
Collaborator

TheLounge is basically the same atm, so I don't feel like moving to it now.

Just closing the loop and not trolling here but I felt the need to point readers of this to the dedicated page listing the differences 😄
There is a lot in it, even though I admit lots are minor. Next release will be huge however and there is more to come before we release. We'll probably go through the PRs you opened to integrate what isn't there already (colors in action messages is fixed for example).

Thanks for your contributions to Shout anyway, and feel free to join the #shout-irc and #thelounge IRC channels! :-)

@bews
Copy link
Author

bews commented May 14, 2016

There is a lot in it, even though I admit lots are minor.

But it still doesn't have the most important feature - auto reconnection :)

We'll probably go through the PRs you opened to integrate what isn't there already

This would be really good.

@astorije
Copy link
Collaborator

But it still doesn't have the most important feature - auto reconnection :)

I knooow... So soon though: thelounge/thelounge#254

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants