Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitterBackend.rooms should use query parameter #21

Open
meetmangukiya opened this issue Jun 23, 2017 · 0 comments
Open

GitterBackend.rooms should use query parameter #21

meetmangukiya opened this issue Jun 23, 2017 · 0 comments

Comments

@meetmangukiya
Copy link
Contributor

meetmangukiya commented Jun 23, 2017 •
edited
Loading

Currently rooms function queries the endpoint without any params, which returns the rooms that the bot has already joined. This is not particularly useful when !room join command is used to join a new room that the bot hasn't joined already.
The endpoint can be passed a query_parameter q, then it can return rooms that the bot hasn't joined as well
meetmangukiya added a commit to meetmangukiya/err-backend-gitter that referenced this issue Jun 23, 2017
@meetmangukiya
gitter: Pass query parameter to readAPIRequest
b8e7d3b 
- New parameter `query` is added to GitterBackend.rooms function. This parameter
  is used while making a request to the rooms endpoint.
- `rooms` function is called with the room uri in in `query_rooms` function.

Closes errbotio#21
@meetmangukiya meetmangukiya mentioned this issue Jun 23, 2017
Closed
meetmangukiya added a commit to meetmangukiya/err-backend-gitter that referenced this issue Jul 4, 2017
@meetmangukiya
gitter: Pass query parameter to readAPIRequest
82fd6b8 
- New parameter `query` is added to GitterBackend.rooms function. This parameter
  is used while making a request to the rooms endpoint.
- `rooms` function is called with the room uri in in `query_rooms` function.

Closes errbotio#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meetmangukiya