gitter: Pass query parameter to readAPIRequest #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbin
requested changes
Jul 4, 2017
gitter.py
Outdated
| def rooms(self): | ||
| json_rooms = self.readAPIRequest('rooms') | ||
| def rooms(self, query=None): | ||
| json_rooms = self.readAPIRequest('rooms', {'q': query}) |
There was a problem hiding this comment.
What happens if room is None ? you need to remove the query.
- New parameter `query` is added to GitterBackend.rooms function. This parameter is used while making a request to the rooms endpoint. - `rooms` function is called with the room uri in in `query_rooms` function. Closes errbotio#21
meetmangukiya
force-pushed
the
meet/room/query_room
branch
from
b8e7d3b to
82fd6b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queryis added to GitterBackend.rooms function. This parameteris used while making a request to the rooms endpoint.
roomsfunction is called with the room uri in inquery_roomsfunction.Closes #21