Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arguments of build_from_json #40

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Fix arguments of build_from_json #40

merged 2 commits into from
Feb 7, 2019

Conversation

abhishalya
Copy link
Contributor

No description provided.

@abhishalya
Change in import statement
35d2caf 
The ErrBot import statement is changed to
```
from errbot.core import ErrBot
```

Closes errbotio#35
@abhishalya
Correct parameters passed to build_from_json function
af20c81 
The arguments to build_from_json were incorrect,
they have been corrected now

Closes errbotio#37
@nvzard nvzard mentioned this pull request Oct 21, 2018
Closed
@abhishalya
Copy link
Contributor Author

@nvzard Can you look at #38 too, I think it is also important.

@nvzard
Copy link
Contributor

nvzard commented Nov 15, 2018

@gbin ping

sijis
sijis approved these changes Feb 1, 2019
View reviewed changes
Copy link

@sijis sijis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine here.

@gbin gbin merged commit 14a428b into errbotio:master Feb 7, 2019
@nvzard nvzard mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvzard nvzard nvzard approved these changes

@sijis sijis sijis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishalya @nvzard @sijis @gbin