Drop Python 3.7 support and update tests #1316

Darkbeast-glitch · 2024-10-10T11:29:58Z

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

Have you followed the guidelines in our Contribution Guide
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Description

Updated the pyproject.toml file to drop all dependencies support 3.7 , removed tests concerned with python version 3.7
Changes to be made

Replace this line with how do you intend to go about getting this done...

Status

Updated the pyroject.toml file and changed all python version from 3.7 to 3.8
To do

If this is a work in progress, Replace this line with your next steps

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #1226

Darkbeast-glitch · 2024-10-11T12:30:48Z

@DhanshreeA please can you check this out please

P-Mefut · 2024-10-12T05:33:30Z

pyproject.toml

@@ -10,7 +10,6 @@ repository = "https://github.com/ersilia-os/ersilia"
 documentation = "https://ersilia.io/model-hub"
 keywords= ["drug-discovery", "machine-learning", "ersilia", "open-science", "global-health", "model-hub", "infectious-diseases"]
 classifiers=[
-        "Programming Language :: Python :: 3.7",
        "Programming Language :: Python :: 3.8",
        "Programming Language :: Python :: 3.9",
        "Programming Language :: Python :: 3.10",


How about added support for python 3.11 here since you've already added it in your code above

so you mean I should add python version 3.11 right?

While you are at it, please mention 3.12 as well, thank you!

Sure please on it

DhanshreeA · 2024-10-12T14:24:40Z

.github/workflows/tests_and_cleanup.yml

@@ -11,7 +11,7 @@ jobs:
  install-ersilia:
    strategy:
      matrix:
-        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.8", "3.9", "3.10", "3.11"]


I think we can also add 3.12 to this list since we support 3.12 as well.

DhanshreeA · 2024-10-12T14:25:10Z

.github/workflows/tests_and_cleanup.yml

@@ -32,7 +32,7 @@ jobs:
  test-docker:
    strategy:
      matrix:
-        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.8", "3.9", "3.10", "3.11"]


Same as above, we can include 3.12 as well.

DhanshreeA · 2024-10-12T14:25:44Z

pyproject.toml

@@ -10,7 +10,6 @@ repository = "https://github.com/ersilia-os/ersilia"
 documentation = "https://ersilia.io/model-hub"
 keywords= ["drug-discovery", "machine-learning", "ersilia", "open-science", "global-health", "model-hub", "infectious-diseases"]
 classifiers=[
-        "Programming Language :: Python :: 3.7",
        "Programming Language :: Python :: 3.8",
        "Programming Language :: Python :: 3.9",
        "Programming Language :: Python :: 3.10",


While you are at it, please mention 3.12 as well, thank you!

DhanshreeA · 2024-10-12T14:26:19Z

pyproject.toml

@@ -49,7 +47,7 @@ numpy = "<=1.26.4"
 isaura = {version="0.1", optional=true}
 pytest = {version = "^7.4.0", optional = true}
 fuzzywuzzy = {version = "^0.18.0", optional = true}
-sphinx = {version = ">=5.3.0", optional = true} # For compatibility with python 3.7.x
+sphinx = {version = ">=5.3.0", optional = true} 


Maybe we actually check which is the minimum version we need for 3.8?

…hix minimum version that support python version 3.8

…-glitch/ersilia into drop-python3.7-support

Darkbeast-glitch · 2024-10-13T15:52:07Z

@DhanshreeA please I made the changes and also worked on your request, kindly verify and let me know if there is anything i need to do , thank you

Darkbeast-glitch · 2024-10-14T08:11:07Z

@DhanshreeA Hello ma, please I am seeing some failures, working to resolve that please.

…-glitch/ersilia into drop-python3.7-support

DhanshreeA · 2024-10-16T06:40:22Z

@Darkbeast-glitch could you please resolve the merge conflicts?

Darkbeast-glitch · 2024-10-16T12:19:02Z

@Darkbeast-glitch could you please resolve the merge conflicts?

sure please on it

Darkbeast-glitch · 2024-10-17T16:13:16Z

@DhanshreeA please I am getting some errors , I think ersilia is failing to install on the python version 12

Ajoke23 · 2024-10-17T17:48:30Z

@Darkbeast-glitch could you post the error you are getting?

Darkbeast-glitch · 2024-10-17T18:49:19Z

@Darkbeast-glitch could you post the error you are getting?

It's coming from the checks, I think 2 are failing, and after checking it's due to the introduction of the python version 3.12

…-glitch/ersilia into drop-python3.7-support

Ajoke23 · 2024-10-18T20:37:58Z

But ersilia support python version 3.12. Did you try to remove 3.12 from the list and run the test, was it successful?

Darkbeast-glitch · 2024-10-21T16:38:07Z

@DhanshreeA please check this if you get time please. Thank you

Darkbeast-glitch · 2024-10-24T17:35:49Z

@DhanshreeA should I drop the python version 3.12, cause ersilia keeps failing to install on that python version , I have Traced back the issue and I added the setup tools buh it still give me that error

DhanshreeA · 2024-10-25T09:51:10Z

Hi @Darkbeast-glitch I've pushed a fix in the culprit file where we were getting the error from. This should make even Python 3.12 work. For reference, the module pkg_resources has been deprecated entirely in favor of importlib in Python 3.12. I have updated the code to use importlib as a drop-in replacement for pkg_resources. My apologies this has taken so long.

Drop Python 3.7 support and update tests

9ce9669

P-Mefut reviewed Oct 12, 2024

View reviewed changes

DhanshreeA requested changes Oct 12, 2024

View reviewed changes

DhanshreeA and others added 3 commits October 12, 2024 19:56

Merge branch 'master' into drop-python3.7-support

4ecc8ed

Update Python versions in workflows and pyproject.toml and changed sp…

e0608f9

…hix minimum version that support python version 3.8

Merge branch 'drop-python3.7-support' of https://github.com/Darkbeast…

83588ef

…-glitch/ersilia into drop-python3.7-support

Merge branch 'master' into drop-python3.7-support

b3b2772

Darkbeast-glitch and others added 3 commits October 14, 2024 08:34

Update Docker images to support Python 3.8 in CircleCI config.yml

772b6f4

Merge branch 'drop-python3.7-support' of https://github.com/Darkbeast…

50c986b

…-glitch/ersilia into drop-python3.7-support

Merge branch 'master' into drop-python3.7-support

39173cd

Darkbeast-glitch and others added 3 commits October 16, 2024 12:22

Merge branch 'master' into drop-python3.7-support

dac8624

Merge branch 'master' into drop-python3.7-support

27a2400

Update config.yml

4635262

Darkbeast-glitch and others added 3 commits October 18, 2024 17:27

Fix setuptools version in pyproject.toml

5b4d37e

Merge branch 'drop-python3.7-support' of https://github.com/Darkbeast…

571a83e

…-glitch/ersilia into drop-python3.7-support

Merge branch 'master' into drop-python3.7-support

0ab3755

DhanshreeA approved these changes Oct 23, 2024

View reviewed changes

Darkbeast-glitch and others added 2 commits October 24, 2024 17:36

Merge branch 'master' into drop-python3.7-support

632d239

Update environment.py

5e60dfe

DhanshreeA merged commit c1a974d into ersilia-os:master Oct 25, 2024
18 checks passed

DhanshreeA mentioned this pull request Oct 25, 2024

🐈 Task: Drop support for Python 3.7 #1226

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop Python 3.7 support and update tests #1316

Drop Python 3.7 support and update tests #1316

Darkbeast-glitch commented Oct 10, 2024

Darkbeast-glitch commented Oct 11, 2024

P-Mefut Oct 12, 2024

Darkbeast-glitch Oct 12, 2024

DhanshreeA Oct 12, 2024

Darkbeast-glitch Oct 13, 2024

DhanshreeA Oct 12, 2024

DhanshreeA Oct 12, 2024

DhanshreeA Oct 12, 2024

DhanshreeA Oct 12, 2024

Darkbeast-glitch Oct 13, 2024

Darkbeast-glitch commented Oct 13, 2024

Darkbeast-glitch commented Oct 14, 2024 •

edited

Loading

DhanshreeA commented Oct 16, 2024

Darkbeast-glitch commented Oct 16, 2024

Darkbeast-glitch commented Oct 17, 2024

Ajoke23 commented Oct 17, 2024

Darkbeast-glitch commented Oct 17, 2024

Ajoke23 commented Oct 18, 2024

Darkbeast-glitch commented Oct 21, 2024 •

edited

Loading

Darkbeast-glitch commented Oct 24, 2024

DhanshreeA commented Oct 25, 2024 •

edited

Loading

Drop Python 3.7 support and update tests #1316

Drop Python 3.7 support and update tests #1316

Conversation

Darkbeast-glitch commented Oct 10, 2024

Darkbeast-glitch commented Oct 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Darkbeast-glitch commented Oct 13, 2024

Darkbeast-glitch commented Oct 14, 2024 • edited Loading

DhanshreeA commented Oct 16, 2024

Darkbeast-glitch commented Oct 16, 2024

Darkbeast-glitch commented Oct 17, 2024

Ajoke23 commented Oct 17, 2024

Darkbeast-glitch commented Oct 17, 2024

Ajoke23 commented Oct 18, 2024

Darkbeast-glitch commented Oct 21, 2024 • edited Loading

Darkbeast-glitch commented Oct 24, 2024

DhanshreeA commented Oct 25, 2024 • edited Loading

Darkbeast-glitch commented Oct 14, 2024 •

edited

Loading

Darkbeast-glitch commented Oct 21, 2024 •

edited

Loading

DhanshreeA commented Oct 25, 2024 •

edited

Loading