-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Shape::Command
only when wasm-bindgen
feature is used
#41
Disable Shape::Command
only when wasm-bindgen
feature is used
#41
Conversation
Hey, I'll look into this today, same for your other PR! |
I'm curious, how do you build your Wasm file? I'd like to try the PR |
Try reading the error. On my end thsi command gives an error in criterion because it's one of the dev dependencies. I'll see if rayon feature can be turned off for wasm target. |
So you're using the same command? |
I tested the PR by building a project that depends on the lib. I now see that I overlooked that exampels also need to run and this was not an obvious issue |
You're only using the svg feature in your project, right? |
No, I'm using image as well |
👌 |
Hmm, that buidl error is weird. I thought cfg attrs worked on enum variants, looks like they don't |
Ah, yes: rustwasm/wasm-bindgen#3297 |
Alright, no more conflicting stuff |
…arch Only when doing JS stuff using wasm-bindgen we need to remove the custom function implementation
9b913c7
to
67a1d46
Compare
Thanks a lot @JohnTheCoolingFan |
Do you need me to release a minor version on crates.io ? |
Yes, an update on crates.io would be very welcome |
Will do soon :) |
Hey @JohnTheCoolingFan, 0.10.3 is up now :) |
Fixes #40
Changed
cfg
andcfg_attr
attributes to do changes that conflict with exposing the api to wasm only when wasm-bindgen is enabled so that teh library can be used in projects compiled for wasm which do not need wasm-bindgen for this crate.