Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use required-features example property instead of compile_error! #42

Merged

Conversation

JohnTheCoolingFan
Copy link
Contributor

This will make cargo enable features needed for the example automatically without the need for checks in teh example via cfg directives

@erwanvivien
Copy link
Owner

Could I rebase the commits in your branch and merge ? :)

@JohnTheCoolingFan
Copy link
Contributor Author

Yes

@erwanvivien erwanvivien force-pushed the general_improvements branch from 91a7101 to ad501d7 Compare October 9, 2023 11:41
@erwanvivien erwanvivien force-pushed the general_improvements branch from ad501d7 to 24f9b25 Compare October 9, 2023 11:41
@erwanvivien erwanvivien merged commit 8ec2fd1 into erwanvivien:master Oct 9, 2023
4 checks passed
@erwanvivien
Copy link
Owner

Big thanks, those are cool changes! I didn't know required-features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants