feat(dashboard): support latest grafana json dashboard model #58
Conversation
There was a problem hiding this comment.
Hey @visheyra I wasn't aware the dashboard couldn't load. Could you give more details? Thanks!
I tried importing it and it many charts failed. I'm leaving some comments. If you tell me what you changed I could probably update my dashboard and launch an upgraded version, but I can't merge yours as it's not ready
| "type": "prometheus", | ||
| "uid": "${DS_PROMETHEUS}" | ||
| }, | ||
| "datasource": {}, |
There was a problem hiding this comment.
This is not good, all panels should reference to the ${DS_PROMETHEUS} variable or they won't work properly when you select another prometheus instance
| "type": "stat" | ||
| }, | ||
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "${DS_PROMETHEUS}" | ||
| "uid": "prometheus" |
There was a problem hiding this comment.
You should use ${DS_PROMETHEUS} and not a specific UID that may not exist for other users
| @@ -411,7 +357,7 @@ | |||
| { | |||
| "datasource": { | |||
| "type": "prometheus", | |||
| "uid": "${DS_PROMETHEUS}" | |||
| "uid": "prometheus" | |||
There was a problem hiding this comment.
Same here, use ${DS_PROMETHEUS}
| }, | ||
| "definition": "label_values(qbittorrent_torrents_count{server=\"$server\"},category)", | ||
| "definition": "label_values(qbittorrent_torrents_count,category)", |
There was a problem hiding this comment.
Why are you removing this query?
| "hide": 0, | ||
| "includeAll": true, | ||
| "includeAll": false, |
There was a problem hiding this comment.
You shouldn't remove this option
| "label": "Categories", | ||
| "multi": true, | ||
| "multi": false, |
There was a problem hiding this comment.
This is also important or you will see only a specific category in the dashboard
| "name": "categories", | ||
| "options": [], | ||
| "query": { | ||
| "qryType": 1, | ||
| "query": "label_values(qbittorrent_torrents_count{server=\"$server\"},category)", | ||
| "query": "label_values(qbittorrent_torrents_count,category)", |
There was a problem hiding this comment.
This shouldn't be removed either
| @@ -1045,6 +969,6 @@ | |||
| "timezone": "", | |||
| "title": "Qbittorrent", | |||
| "uid": "eKyTETFMk", | |||
| "version": 58, | |||
| "version": 1, | |||
There was a problem hiding this comment.
It's not a good idea to reset the dashboard version
Hi @esanchezm I updated your dashboard.json so the latest grafana would be able to load it :) feel free to tell me if you need additional changes, thanks for the exporter !!!