Skip to content

Commit

Permalink
Merge pull request #32 from esbenp/laravel-7
Browse files Browse the repository at this point in the history
Laravel 7
  • Loading branch information
esbenp authored Oct 31, 2020
2 parents a3cf312 + 8a17a1f commit 04bf9b3
Show file tree
Hide file tree
Showing 12 changed files with 26 additions and 26 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
]
},
"require": {
"laravel/framework": "~6.0"
"laravel/framework": "~7.0"
},
"require-dev": {
"mockery/mockery": "1.3.*",
Expand Down
8 changes: 4 additions & 4 deletions src/ExceptionHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Optimus\Heimdal;

use Exception;
use Throwable;
use ReflectionClass;
use InvalidArgumentException;
use Asm89\Stack\CorsService;
Expand Down Expand Up @@ -40,7 +40,7 @@ public function __construct(Container $container)
* @throws Exception
* @returns void
*/
public function report(Exception $e)
public function report(Throwable $e)
{
parent::report($e);

Expand Down Expand Up @@ -86,7 +86,7 @@ public function report(Exception $e)
* @param Exception $e
* @return \Symfony\Component\HttpFoundation\Response
*/
public function render($request, Exception $e)
public function render($request, Throwable $e)
{
$response = $this->generateExceptionResponse($request, $e);

Expand All @@ -112,7 +112,7 @@ public function render($request, Exception $e)
* @param Exception $e
* @return mixed
*/
private function generateExceptionResponse($request, Exception $e)
private function generateExceptionResponse($request, Throwable $e)
{
$formatters = $this->config['formatters'];

Expand Down
4 changes: 2 additions & 2 deletions src/Formatters/BaseFormatter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Optimus\Heimdal\Formatters;

use Exception;
use Throwable;
use Illuminate\Http\JsonResponse;

abstract class BaseFormatter
Expand All @@ -17,5 +17,5 @@ public function __construct(array $config, $debug)
$this->config = $config;
}

abstract protected function format(JsonResponse $response, Exception $e, array $reporterResponses);
abstract protected function format(JsonResponse $response, Throwable $e, array $reporterResponses);
}
4 changes: 2 additions & 2 deletions src/Formatters/ExceptionFormatter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

namespace Optimus\Heimdal\Formatters;

use Exception;
use Throwable;
use Illuminate\Http\JsonResponse;
use Optimus\Heimdal\Formatters\BaseFormatter;

class ExceptionFormatter extends BaseFormatter
{
public function format(JsonResponse $response, Exception $e, array $reporterResponses)
public function format(JsonResponse $response, Throwable $e, array $reporterResponses)
{
$response->setStatusCode(500);
$data = $response->getData(true);
Expand Down
6 changes: 3 additions & 3 deletions src/Formatters/HttpExceptionFormatter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

namespace Optimus\Heimdal\Formatters;

use Exception;
use Throwable;
use Illuminate\Http\JsonResponse;
use Optimus\Heimdal\Formatters\ExceptionFormatter;

class HttpExceptionFormatter extends ExceptionFormatter
{
public function format(JsonResponse $response, Exception $e, array $reporterResponses)
public function format(JsonResponse $response, Throwable $e, array $reporterResponses)
{
parent::format($response, $e, $reporterResponses);

if (count($headers = $e->getHeaders())) {
$response->headers->add($headers);
}
Expand Down
6 changes: 3 additions & 3 deletions src/Formatters/UnprocessableEntityHttpExceptionFormatter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

namespace Optimus\Heimdal\Formatters;

use Exception;
use Throwable;
use Illuminate\Http\JsonResponse;
use Optimus\Heimdal\Formatters\BaseFormatter;

class UnprocessableEntityHttpExceptionFormatter extends BaseFormatter
{
public function format(JsonResponse $response, Exception $e, array $reporterResponses)
public function format(JsonResponse $response, Throwable $e, array $reporterResponses)
{
$response->setStatusCode(422);

// Laravel validation errors will return JSON string
$decoded = json_decode($e->getMessage(), true);
// Message was not valid JSON
Expand Down
4 changes: 2 additions & 2 deletions src/Reporters/BugsnagReporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Optimus\Heimdal\Reporters;

use Exception;
use Throwable;
use Bugsnag\Client;
use InvalidArgumentException;

Expand All @@ -29,7 +29,7 @@ public function __construct(array $config)
*
* @param Exception $exception
*/
public function report(Exception $exception)
public function report(Throwable $exception)
{
return $this->client->notifyException($exception);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Reporters/ReporterInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Optimus\Heimdal\Reporters;

use Exception;
use Throwable;

interface ReporterInterface
{
public function report(Exception $e);
public function report(Throwable $e);
}
4 changes: 2 additions & 2 deletions src/Reporters/RollbarReporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Optimus\Heimdal\Reporters;

use Exception;
use Throwable;
use Rollbar;
use InvalidArgumentException;

Expand All @@ -28,7 +28,7 @@ public function __construct(array $config)
* @param Exception $exception
* @return string|void
*/
public function report(Exception $exception)
public function report(Throwable $exception)
{
return Rollbar::report_exception($exception);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Reporters/SentryReporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Optimus\Heimdal\Reporters;

use Exception;
use Throwable;
use InvalidArgumentException;
use Raven_Client;
use Optimus\Heimdal\Reporters\ReporterInterface;
Expand All @@ -22,7 +22,7 @@ public function __construct(array $config)
$this->config = $config;
}

public function report(Exception $e)
public function report(Throwable $e)
{
$options = $this->config['sentry_options'];

Expand Down
4 changes: 2 additions & 2 deletions src/ResponseFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

namespace Optimus\Heimdal;

use Exception;
use Throwable;
use Illuminate\Http\JsonResponse;

class ResponseFactory
{
public static function make(Exception $e)
public static function make(Throwable $e)
{
return new JsonResponse([
'status' => 'error'
Expand Down
2 changes: 1 addition & 1 deletion src/config/optimus.heimdal.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
'formatters' => [
SymfonyException\UnprocessableEntityHttpException::class => Formatters\UnprocessableEntityHttpExceptionFormatter::class,
SymfonyException\HttpException::class => Formatters\HttpExceptionFormatter::class,
Exception::class => Formatters\ExceptionFormatter::class,
Throwable::class => Formatters\ExceptionFormatter::class,
],

'response_factory' => \Optimus\Heimdal\ResponseFactory::class,
Expand Down

0 comments on commit 04bf9b3

Please sign in to comment.