Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first update of episode 5 #104

Merged
merged 24 commits into from
May 8, 2024
Merged

first update of episode 5 #104

merged 24 commits into from
May 8, 2024

Conversation

fnattino
Copy link
Collaborator

@fnattino fnattino commented Feb 28, 2024

TODOs:

  • Can we make final exercise more fitting to the new narrative?
  • Update the code cell output after the collection has been updated

Copy link

github-actions bot commented Feb 28, 2024

❌ DANGER ❌

This pull request has modified workflows that created output. Close this now.

github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
@Morrizzzzz
Copy link

@fnattino

I went through episode 5 as well (I knew you were doing this, but since I was trying to get the data for the total viewshed idead lateron I could not resist to add comments/ update it). I have quite some comments and added a lot of clarifying text in a separate branch based on main. Just let me know whenever yours is done so I can compare mine with the main you will have at that moment.

@fnattino
Copy link
Collaborator Author

fnattino commented Mar 6, 2024

Hi @Morrizzzzz, thanks. The changes I had introduced so far are all in here. However I still need to update the collection used in here, the one we are using will be deprecated at some point (see discussion Element84/earth-search#31) .

github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
@Morrizzzzz Morrizzzzz changed the base branch from main to draft_30042024 April 30, 2024 08:50
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@fnattino fnattino marked this pull request as ready for review May 2, 2024 13:16
@Morrizzzzz
Copy link

Just finished epi 6 @fnattino can you please review it?

github-actions bot pushed a commit that referenced this pull request May 3, 2024
Copy link
Collaborator

@rogerkuou rogerkuou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the notebook

@rogerkuou rogerkuou merged commit 0fe77f7 into draft_30042024 May 8, 2024
2 checks passed
@Morrizzzzz Morrizzzzz deleted the issue-90 branch June 25, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants