Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 update figshare #117

Merged
merged 3 commits into from
May 8, 2024
Merged

115 update figshare #117

merged 3 commits into from
May 8, 2024

Conversation

rogerkuou
Copy link
Collaborator

@rogerkuou rogerkuou commented May 2, 2024

This should be merged after PR #112.

fix #115

@Morrizzzzz I have uploaded data on Figshare and updated the setup instruction. Please review and merge PR #112 first, since this PR also uses part of changes in PR 112.

Data updated in Figshare: https://figshare.com/ndownloader/articles/25721754

BTW, I also attached the notebook used to download image: ep5_prepare_data.zip, in case you want to check how the images are created.

@rogerkuou rogerkuou requested a review from Morrizzzzz May 2, 2024 14:58
Copy link

github-actions bot commented May 2, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/geospatial-python/compare/md-outputs..md-outputs-PR-117

The following changes were observed in the rendered markdown documents:

 01-intro-raster-data.md                       |  62 ++--
 02-intro-vector-data.md                       |  30 +-
 03-crs.md                                     |  20 +-
 04-geo-landscape.md                           |  24 +-
 07-vector-data-in-python.md                   | 482 ++++++++++++--------------
 08-crop-raster-data.md                        | 266 ++++++--------
 fig/E07/greece_administration_areas.png (new) | Bin 0 -> 64055 bytes
 fig/E07/greece_highways.png (new)             | Bin 0 -> 26479 bytes
 fig/E07/rhodes_administration_areas.png (new) | Bin 0 -> 17351 bytes
 fig/E07/rhodes_assets.png (new)               | Bin 0 -> 45400 bytes
 fig/E07/rhodes_builtup_buffer.png (new)       | Bin 0 -> 18396 bytes
 fig/E07/rhodes_highways.png (new)             | Bin 0 -> 80495 bytes
 fig/E07/rhodes_infra_highways.png (new)       | Bin 0 -> 46913 bytes
 fig/E08/dem.png (new)                         | Bin 0 -> 98203 bytes
 fig/E08/dem_matched.png (new)                 | Bin 0 -> 122237 bytes
 fig/E08/visual_clip.png (new)                 | Bin 0 -> 77146 bytes
 fig/E08/visual_clip_box.png (new)             | Bin 0 -> 374262 bytes
 fig/E08/visual_large.png (new)                | Bin 0 -> 197716 bytes
 index.md                                      |  30 +-
 md5sum.txt                                    |  16 +-
 setup.md                                      |  27 +-
 21 files changed, 430 insertions(+), 527 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-03 07:46:47 +0000

github-actions bot pushed a commit that referenced this pull request May 2, 2024
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@rogerkuou
Copy link
Collaborator Author

Hi @Morrizzzzz, I updated to the figshare link to: https://figshare.com/ndownloader/articles/25721754/versions/3. This one is with a version number and it works.

Copy link

@Morrizzzzz Morrizzzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been reviewed in PK 110

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerkuou you reviewed this in issue 92, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to improve the readability of the map, maybe put the legend down and use more distinct colors for the legend items.

@rogerkuou rogerkuou changed the base branch from main to draft_30042024 May 8, 2024 09:53
@rogerkuou rogerkuou merged commit a0ac88e into draft_30042024 May 8, 2024
3 checks passed
@Morrizzzzz Morrizzzzz deleted the 115_update_figshare branch June 25, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update figshare
2 participants