-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
115 update figshare #117
115 update figshare #117
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/geospatial-python/compare/md-outputs..md-outputs-PR-117 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-05-03 07:46:47 +0000 |
Hi @Morrizzzzz, I updated to the figshare link to: https://figshare.com/ndownloader/articles/25721754/versions/3. This one is with a version number and it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
episodes/08-crop-raster-data.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been reviewed in PK 110
episodes/07-vector-data-in-python.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogerkuou you reviewed this in issue 92, right?
episodes/fig/E07/rhodes_assets.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to improve the readability of the map, maybe put the legend down and use more distinct colors for the legend items.
This should be merged after PR #112.
fix #115
@Morrizzzzz I have uploaded data on Figshare and updated the setup instruction. Please review and merge PR #112 first, since this PR also uses part of changes in PR 112.
Data updated in Figshare: https://figshare.com/ndownloader/articles/25721754
BTW, I also attached the notebook used to download image: ep5_prepare_data.zip, in case you want to check how the images are created.