Added Groups functionality #13
Conversation
…in a certain group. Add a contact to a group
|
Updated to Allow Groups to be Added or Deleted. Add Contact to a Group. Get list of Contacts within a Group. |
|
Hi John, Apologies for the delay in reviewing this pull request. I've given it a check over and it looks great, definitely a valuable contribution to the code base. However it seems as though there has been a merge issue - some files have been removed from the solution; namely the recent surveys code. Seems the files in question still remain in the folder structure, for example, so if you could include these back into the project we can finalise the code review and get it merged. n.b We're hoping to get a Travis Pipeline setup which should help verify your code changes further. If you need any assistance please drop us a comment! Thanks, Jack |
| try | ||
| { | ||
| var collection = groupService.GetGroups(_accountReference, PageIndex, PageSize); | ||
| var contacts = new PagedContactCollection(); |
There was a problem hiding this comment.
This can be inlined with the contact creation.
|
I've merged in #14. Can you rebase/merge from master and push again? You should see this pull request build on Travis. |
|
Hi Jack, Sorry for not getting back to you on this. I will rebase/merge from master and push the changes again. |
|
Hello again, Have you got any feedback on the comments made earlier by Jack? If you're able to it would be good to address them and we'll have a look at accepting your pull request and merging it in. Thanks again for your input, |
|
Hi Robin, Sorry for the late reply I'm going to get this done. |
Conflicts: source/Properties/AssemblyInfo.cs source/com.esendex.sdk.csproj test/com.esendex.sdk.test.csproj test/packages.config
…sing stuff from files.
Updated to Allow Groups to be Added or Deleted. Add Contact to a Group. Get list of Contacts within a Group.