Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tool MWA to 0.0.4+galaxy0 #73

Closed
wants to merge 2 commits into from

Conversation

dsavchenko
Copy link
Collaborator

No description provided.

<when value="Spectrum">
<param name="src_name" type="text" value="1ES 0229+200" label="src_name" />
<param name="RA" type="float" value="38.202562" label="RA Units: deg" />
<param name="DEC" type="float" value="20.288191" label="DEC Units: deg" />
Copy link
Collaborator

@bgruening bgruening Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a very silly question ... is deg degree? And do you think it would make sense to have a type="deg"? What would such a type have as properties?

You could also add a min="" and max="" to all degree's I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a very silly question ... is deg degree? And do you think it would make sense to have a type="deg"? What would such a type have as properties?

Yes, deg is a degree. It's often represented with float, so this works well for the moment, it directly corresponds to the original notebook input.

But I can imagine some more generic angle field. It can have units and format, this will define how the value is passed to the job, e.g. 1.5 deg = 90 arcmin = 1d30m0.0s = 0h6m0s etc.
And the UI may provide a possibility to input it in different formats and even offer some widget

The same could be applicable to the time input (more precisely, time instant). This can also have different formats including more astronomy-specific representations like "modified Julian day"

Thinking even broader, many inputs can have unit and galaxy may provide the unit conversion under the hood based on some ontology of the units of measure. ( But it seems I went too far :)

You could also add a min="" and max="" to all degree's I think.

Thank you, this is applicable especially to DEC, which is bounded [-90;90] by definition. I should check if this is expressed in our ontology. The bot should follow it when generating tools.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for all the insights. I think Galaxy is very open to extending the available types if there is a need for a specific community. Similar to the color type that we have.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we are currently dealing with, out of galaxy context, is the structured input type, e.g. a table that gets encoded as a dict of lists. At some point, we will need to find a way to have such a form of input in galaxy. So we will most likely try to extend this part

Co-authored-by: Björn Grüning <[email protected]>
@dsavchenko dsavchenko closed this Jan 31, 2024
@dsavchenko dsavchenko deleted the auto-update-galaxy-tool-mwa-v0.0.4-galaxy0 branch January 31, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants